Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxying to an https registry #6771

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Fix proxying to an https registry #6771

merged 3 commits into from
Sep 8, 2023

Conversation

lukekarrys
Copy link
Contributor

Ref: #6760

@lukekarrys lukekarrys requested a review from a team as a code owner September 7, 2023 23:33
@lukekarrys
Copy link
Contributor Author

@wraithgar this is ready for review now. the update to @npmcli/agent is in this PR and should fix the failing smoke test

@lukekarrys lukekarrys changed the title chore: add smoke-test to proxy live registry Fix proxying to an https registry Sep 8, 2023
wraithgar
wraithgar reviewed Sep 8, 2023
View reviewed changes
DEPENDENCIES.md Outdated Show resolved Hide resolved
@lukekarrys lukekarrys force-pushed the lk/smoke-test-proxy-real-registry branch from 109269a to 63bdc10 Compare September 8, 2023 19:19
@lukekarrys lukekarrys force-pushed the lk/smoke-test-proxy-real-registry branch from 63bdc10 to 63b5ee6 Compare September 8, 2023 20:17
@lukekarrys lukekarrys merged commit a85945b into latest Sep 8, 2023
32 checks passed
@lukekarrys lukekarrys deleted the lk/smoke-test-proxy-real-registry branch September 8, 2023 20:32
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
Merged
This was referenced Sep 8, 2023
Closed
Merged
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukekarrys @wraithgar