This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
Major release: 2.0 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript can't pick up custom modules (e.g. declare module 'shopify-prime/models') when installed in another project. Unfortunately declarations need to be imported as objects into the main definition file to be compile and picked up correctly. See also: http:https://stackoverflow.com/questions/40308986/how-do-i-include-extra-typescript-declarations-when-i-publish-my-package-to-npm
Including these exports would also include them in the generated js file. Because these exports were only TS interfaces and not real js objects, node would immediately throw an error because it couldn't find any corresponding module for them.
[ci skip]
|
Whoa, quite the update. I was about to submit a PR with my changes before I realised the extent of changes you've made. We've actually made a lot of the same changes when upgrading to ts 2.x. PR should land soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release restructures the lib's exports and TypeScript definitions, and also adds support for Shopify's Orders API.