Skip to content
This repository has been archived by the owner on Dec 2, 2019. It is now read-only.

Added theme assets api #28

Merged
merged 5 commits into from
Dec 18, 2018
Merged

Conversation

JumpLink
Copy link
Contributor

@JumpLink JumpLink commented Oct 16, 2018

The next one 😁

  • Added support for the theme assets shopify api

Please note, so far I have only tested the get and list methods, and they are working

@JumpLink
Copy link
Contributor Author

I will update some other stuff before I recreate this PR

@JumpLink JumpLink closed this Oct 17, 2018
@JumpLink JumpLink reopened this Oct 18, 2018
@JumpLink
Copy link
Contributor Author

Okay now it looks better :)

Copy link
Owner

@nozzlegear nozzlegear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I've requested a few small changes to keep the Assets service in line with the "style" of the rest of the services.

services/assets.ts Outdated Show resolved Hide resolved
services/assets.ts Outdated Show resolved Hide resolved
services/assets.ts Outdated Show resolved Hide resolved
models/asset.ts Outdated Show resolved Hide resolved
models/asset.ts Outdated Show resolved Hide resolved
@JumpLink
Copy link
Contributor Author

Okay, now everything should be as desired :)

Changes taken from master
Copy link
Contributor Author

@JumpLink JumpLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved

@nozzlegear nozzlegear merged commit 4083798 into nozzlegear:master Dec 18, 2018
@nozzlegear
Copy link
Owner

Published in 2.12.0, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants