This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
Fixed Fulfillment Support and Added Product Variant Support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, I wish I would have seen this just 30 seconds ago before I published 2.6.0! I'll look it over as soon as I get a chance. |
|
:( Sorry |
jdalrymple
changed the title
|
Sorry, I let this get away from me! I see you've added some commits, is this still ready to merge? |
|
Yup I added variants as well. I'll do more testing today to ensure things are on point, but should be good by tomorrow :) |
|
Any chance this PR could be accepted ? |
|
Sorry, I dropped the ball on this. Your changes should be published in NPM in version 2.7.0. Thank you! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more testing i found some serious bugs with the fulfillments support added in the last PR. Fixed them in this one! Please give it a once over to make sure i didnt miss anything.