Skip to content
This repository has been archived by the owner on Dec 2, 2019. It is now read-only.

Added refunds and price rule apis #14

Merged
merged 3 commits into from
May 21, 2017
Merged

Conversation

dcworldwide
Copy link
Contributor

Included price rule tests.

… fulfillment and payment. Enriched order and payment views to show fulfillment status and ensured that we only ever show the orderTotalPreShippingTax to As. Also we now store the raw shopify order object in the database so we can recover from logic issues and handle customer disputes. Upgraded shopify library to handle price rule api and order refunds. Hopefully optimised the RHS panel which appeared to trigger excessive page rendering. Pushed to production.
@nozzlegear nozzlegear merged commit 9b86987 into nozzlegear:master May 21, 2017
@nozzlegear
Copy link
Owner

Thanks for the pull request! I had to skip the price rules tests because they were failing on the CI build without a Shopify Plus store.

Your changes should be available on NPM with version 2.4.0.

@dcworldwide
Copy link
Contributor Author

Thanks!

Actually they are a new non plus apI just released.

@nozzlegear
Copy link
Owner

Oh I see that now, I was getting 403 forbidden errors and just figured it was because the Price Rules were only for Plus accounts or something. I'll have to look closer!

@nozzlegear
Copy link
Owner

I finally figured out why the price rules tests are failing. When trying to create a price rule, Shopify is returning an error that says "[API] This action requires merchant approval for write_price_rules scope.". It looks like Shopify has made a change to private apps; where previously they had automatic access to all scopes, merchants must now give them specific scopes. Old private apps get grandfathered in and keep access to all previous scopes, but new scopes (like the price rules scope) must be turned on by the merchant.

@dcworldwide
Copy link
Contributor Author

Ah that makes sense. I had to uninstall my apps then explicitly request the new scopes as well.

It's a little ugly the way they've preserved the old discount api but I imagine it won't be deprecated for some time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants