Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Some changes to allow more customization #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

zliw
Copy link

@zliw zliw commented May 13, 2014

Hello Dmitry, Hello Ronny,

As you probably are already aware, I dabbled a little bit with your project. I don't know, if you're agreeable with the changes I made, but have a look yourself. Most important points:

  • I decoupled the date picker from the date view, so users can subclass/replace the built-in DIDatePickerDateView
  • The date view is now configurable via a dictionary exposed via the date picker, allowing for configuration of fonts and colors
  • the size of the date view is now declared by the view class
  • the space between the views is now configurable at runtime via a property
  • I left the current APIs implementing a subset of this intact, so there hopefully won't be no impact to existing users. But as the version number is quite low, we could also discuss just to leave them out.

What do you think?

Best Regards,
Martin

zliw added 4 commits May 12, 2014 17:23
…ormer spacing constant is now a property of DIDatepicker, removed unused constants
…tionary, which may be set on DIDatePicker. left old partial configuration intact for backwards compability
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant