fix(js): inbox notifications component gets remounting when render notification prop changes #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
commented
Sep 2, 2024
| @@ -75,13 +79,14 @@ export const Renderer = (props: RendererProps) => { | |||
| <FocusManagerProvider> | |||
| <InboxProvider tabs={props.tabs}> | |||
| <CountProvider> | |||
| <For each={[...props.nodes]}> | |||
| {([node, component]) => { | |||
| <For each={nodes()}> | |||
There was a problem hiding this comment.
The nodes aka DOM element refs don't change on re-render, so it's "safe" to use them in the For component each prop as the Solid is doing comparison based on refs when rendering DOM elements. This code will make sure that the corresponding Solid components won't remount on props change.
| {([node, component]) => { | ||
| <For each={nodes()}> | ||
| {(node) => { | ||
| const novuComponent = createMemo(() => props.nodes.get(node)!); |
There was a problem hiding this comment.
However, the Solid component props might change, which is why we should memoize it and update the signal when it has been changed.
|
|
||
| export default function Home() { | ||
| const [count, setCount] = useState(0); |
There was a problem hiding this comment.
This is the playground code to verify that the state changes are propagated but the Notifications component doesn't get remounted.
desiprisg
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Fixed the issue described in this ticket: https://linear.app/novu/issue/COM-199/the-inbox-notifications-component-gets-remounted-when
Screenshots
Screen.Recording.2024-09-02.at.18.45.44.mov