fix(framework): Remove only failing validation properties and simplify Slack schema #6160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Jul 25, 2024
| @@ -20,7 +20,7 @@ export class JsonSchemaValidator implements Validator<JsonSchema> { | |||
| // https://ajv.js.org/options.html#usedefaults | |||
| useDefaults: true, | |||
| // https://ajv.js.org/options.html#removeadditional | |||
| removeAdditional: 'all', | |||
| removeAdditional: 'failing', | |||
There was a problem hiding this comment.
This was the important change to ensure that specifying additionalProperties: true on the schema is acted upon, maintaining the additional properties. Previously, all additional properties were being removed, ignoring this schema property.
rifont
commented
Jul 25, 2024
| @@ -36,7 +37,7 @@ export type ExecuteOutputOptions = { | |||
|
|
|||
| export type ExecuteOutput = { | |||
| outputs: Record<string, unknown>; | |||
| providers?: Record<string, Record<string, unknown>>; | |||
| providers?: Record<string, WithPassthrough<Record<string, unknown>>>; | |||
There was a problem hiding this comment.
Adding a missing type here.
| @@ -40,7 +40,7 @@ describe('validators', () => { | |||
| title: 'should remove additional properties and successfully validate', | |||
| schemas: { | |||
| zod: z.object({ name: z.string() }), | |||
| json: { type: 'object', properties: { name: { type: 'string' } } } as const, | |||
| json: { type: 'object', properties: { name: { type: 'string' } }, additionalProperties: false } as const, | |||
There was a problem hiding this comment.
Necessary to fix the failing test after modifying the removeAdditional property in the JsonSchema validator.
davidsoderberg
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
if/thenstyle of JsonSchem syntax. We will need to revisit adding type support for Slack blocks by using explicitly generated Typescript typings from the Slack blocks JsonSchema to reduce the burden on Typescripts inference engine.Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer