feat(js): inbox support multiple counts for the provided filters #6159
Conversation
| const filters = JSON.parse(value); | ||
| if (Array.isArray(filters)) { | ||
| return filters.map((el) => plainToClass(NotificationsFilter, el)); | ||
| } |
There was a problem hiding this comment.
The filters are sent in the query params as the stringified JSON object. We need to parse it back from string to object and run the validation on its fields.
There was a problem hiding this comment.
The stringified JSON filters in counts creates a discrepancy between the count and the notifications endpoint where one filter is specified via separate query string parameters.
I don't have a good suggestion yet but I suggest we add a task to revise this post-release and opt-in for more alignment between the two endpoints.
| } catch (error) { | ||
| this._emitter.emit('feeds.fetch_count.error', { args, error }); | ||
| throw error; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| async read(args: BaseArgs): Promise<Notification>; |
| const response = await novu.feeds.fetchCount(payload); | ||
| const count = response.data.count; | ||
| onSuccess?.(count); | ||
| const [unreadCount, { refetch }] = createResource( |
There was a problem hiding this comment.
this hook is not used but I had to update it's code
39bbf3c
to
b99ce01
Compare
| const filters = JSON.parse(value); | ||
| if (Array.isArray(filters)) { | ||
| return filters.map((el) => plainToClass(NotificationsFilter, el)); | ||
| } |
There was a problem hiding this comment.
The stringified JSON filters in counts creates a discrepancy between the count and the notifications endpoint where one filter is specified via separate query string parameters.
I don't have a good suggestion yet but I suggest we add a task to revise this post-release and opt-in for more alignment between the two endpoints.
apps/api/src/app/inbox/usecases/notifications-count/notifications-count.usecase.ts
Show resolved
Hide resolved
fe1cd2a
to
10d18ab
Compare
What changed? Why was the change needed?
In this PR:
GET /notifications/countsendpoint which supports multiple filters in query params as JSON objectScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer