feat(web): add v2 components for docs #5975
Conversation
| @@ -81,6 +97,10 @@ export const Docs = ({ code = '', description = '', title = '', isLoading, child | |||
| } | |||
|
|
|||
| if (Component === null) { | |||
| if (isChildDocs) { | |||
| return <Text>We could not load this part of the documentation for you. Please try again.</Text>; | |||
There was a problem hiding this comment.
In what scenario will this happen? And what will change if the user will try again?
There was a problem hiding this comment.
If the docs could not be fetched from github for some reason. It could if it is github that is the issue. For me it is more a being nice to the user thing.
9ab8345
to
9f2a916
Compare
| <Flex justify="space-between" align="center"> | ||
| <TitleH1 | ||
| className={css({ | ||
| width: '99%', |
There was a problem hiding this comment.
❓ question: Why do we need this?
There was a problem hiding this comment.
Because otherwise the floating close icon and external link will be hiding part of the title
There was a problem hiding this comment.
Hmm, then there's probably a solution that may address it more directly that would be better to aim for
apps/web/src/components/layout/components/v2/BridgeUpdateModal.tsx
Outdated
Show resolved
Hide resolved
| <Flex justify="space-between" align="center"> | ||
| <TitleH1 | ||
| className={css({ | ||
| width: '99%', |
There was a problem hiding this comment.
Hmm, then there's probably a solution that may address it more directly that would be better to aim for
75ca517
to
e58726d
Compare
bc79dc0
to
317f407
Compare
|
@davidsoderberg can we get this merged? |
No description provided.