fix(framework): bug with duplicate step names #5921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denis-kralj-novu
commented
Jul 2, 2024
- Move error detection to action endpoints
- Remove throwing on ID collision, log error instead
- Add tests
b5b0a6e
to
3b964d6
Compare
❌ Deploy Preview for novu-design failed. Why did it fail? →
|
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
106f168
to
522c4e7
Compare
Move error detection to action endpoints Remove throwing on ID collision, log error instead Add tests
Lint adjustments
Lint adjustments
522c4e7
to
ce786e8
Compare
denis-kralj-novu
commented
Jul 2, 2024
| [PostActionEnum.EXECUTE]: async () => { | ||
| const errors = this.client.getErrors(); |
There was a problem hiding this comment.
❓ question: what is the usecase for execute? I'm not sure how it gets used in the studio and the bridge api client doesn't seem to use the action.
denis-kralj-novu
commented
Jul 2, 2024
|
|
||
| return this.createResponse(HttpStatusEnum.OK, result); | ||
| }, | ||
| [GetActionEnum.CODE]: async () => { | ||
| const result = await this.client.getCode(workflowId, stepId); | ||
| const errors = this.client.getErrors(); |
There was a problem hiding this comment.
❓ question: same as execute, what is the usecase for code? I'm not sure how it gets used in the studio and the bridge api client doesn't seem to use the action.
Place errors in a dedicated property in response object
SokratisVidros
requested changes
Jul 3, 2024
|
|
||
| const workflowIds = this.discoveredWorkflows.map((discoveredWorkflow) => discoveredWorkflow.workflowId); | ||
|
|
||
| const workflowOccuranceMap = this.getOccuranceMap(workflowIds); |
There was a problem hiding this comment.
suggestion: We can do this check in a single pass with an assert function that will throw an error in the first duplicate detection using a reduce function. The accumulator is the occuranceMap.
| [PostActionEnum.EXECUTE]: async () => { | ||
| const errors = this.client.getErrors(); | ||
|
|
||
| if (errors.length !== 0) { |
There was a problem hiding this comment.
Let's generalize error handling across all action types to make the code dryer. Every byte counts in the framework SDK.
|
|
||
| return this.createResponse(HttpStatusEnum.OK, result); | ||
| }, | ||
| [GetActionEnum.CODE]: async () => { | ||
| const result = await this.client.getCode(workflowId, stepId); | ||
| const errors = this.client.getErrors(); |
| [PostActionEnum.EXECUTE]: async () => { | ||
| const errors = this.client.getErrors(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.