Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: add methods for product attributes #1

Merged
merged 1 commit into from
Mar 15, 2017
Merged

new: add methods for product attributes #1

merged 1 commit into from
Mar 15, 2017

Conversation

XianHain
Copy link
Contributor

This adds an additional API endpoint for product attributes.

I did my best to match existing coding styles. The only major difference is one of the tests needs to pull the attributeId of the existing attribute before it can update it.

Copy link
Owner

@nouvak nouvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Christian!
The patch looks ok!
Thanks for contributing! :)

@nouvak nouvak merged commit a63e76e into nouvak:master Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants