doc: Translate some part into English #31
Conversation
README.md
Outdated
| NES.cssはCSSのみで構成されています。JavaScriptは不要です。 | ||
|
|
||
|
|
||
| ## Browser Support | ||
|
|
||
| NES.css is compatible with the newest version of below browsers. |
There was a problem hiding this comment.
Proposed:
NES.css is compatible with the newest version of the following browsers.
README.md
Outdated
| @@ -44,17 +47,23 @@ TODO: 詳細を書く | |||
|
|
|||
| ## CSS Only | |||
|
|
|||
| NES.css only require CSS. You can use this without JavaScript. | |||
There was a problem hiding this comment.
Proposed:
NES.css only requires CSS and doesn't depend on any JavaScript.
README.md
Outdated
| ## Usage | ||
|
|
||
| NES.css is only providing component. You can define your layout. |
There was a problem hiding this comment.
Proposed:
NES.css only provides components. You will need to define your own layout.
There was a problem hiding this comment.
- You will need to define your own layout?
README.md
Outdated
| ## Usage | ||
|
|
||
| NES.css is only providing component. You can define your layout. | ||
|
|
||
| Default font is `Press Start 2P`. When you using this framework with any language except English (link Japanese), please use another font as necessary. |
There was a problem hiding this comment.
Proposed:
The default font is
Press Start 2Pwhich only supports English characters. When you're using this framework with any language except English, please use another font.
Should link Japanese be an actual link?
There was a problem hiding this comment.
It would be good to keep a more permanent link alternative available for this font
There was a problem hiding this comment.
Here's the link from Dafont https://www.dafont.com/press-start-2p.font
Correction, authors link is better since this would be a better source for licensing as well.
https://www.zone38.net/font/
There was a problem hiding this comment.
That's a typo. It's "like", not "link". Sorry.
README.md
Outdated
| 次のブラウザの最新バージョンをサポートしています。 | ||
|
|
||
| * Chrome | ||
| * Firefox | ||
| * Safari | ||
|
|
||
| Not test |
|
I'm not good at English, so I really appreciate this PR 😍 |
|
@JamesIves Thank for the suggests. I have pushed a new commit, can you please check again? |
|
Looks good to me! |
|
Hey I (mistakenly, I didn't check properly beforehand) created a whole new PR for this, although I split the README into Japanese-only and English-only. Should I close it myself? |
|
Thank you everyone 😍 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.