Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diag_ggn #81

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Add diag_ggn #81

merged 5 commits into from
Apr 30, 2024

Conversation

SamDuffield
Copy link
Contributor

  • Add diag_ggn function to calculate the diagonal of a Generalized Gauss-Newton matrix
  • Add tests (mimicking ggn)

KaelanDt
KaelanDt requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from quick docstring fix

posteriors/utils.py Outdated Show resolved Hide resolved
posteriors/utils.py Show resolved Hide resolved
@SamDuffield SamDuffield merged commit 8bc8672 into main Apr 30, 2024
2 checks passed
@SamDuffield SamDuffield deleted the ggn-diag branch April 30, 2024 09:55
@SamDuffield SamDuffield mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelanDt KaelanDt KaelanDt approved these changes

@johnathanchiu johnathanchiu Awaiting requested review from johnathanchiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamDuffield @KaelanDt