Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build using setuptools.build_meta backend #51

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Build using setuptools.build_meta backend #51

merged 3 commits into from
Apr 16, 2024

Conversation

SamDuffield
Copy link
Contributor

@SamDuffield SamDuffield commented Apr 16, 2024 •
edited
Loading

Now the package will install properly from PyPI (I've tested using TestPyPI)

The fix was to specify [build-system] in pyproject.toml.

Additionally added

  • Test in the publish_pypi.yaml workflow to check the build imports ok
  • Upgrade Ruff version
  • Add accessible __version__ attribute to package
  • Bumped version to 0.0.2 (you cannot overwrite versions on PyPI)

@SamDuffield SamDuffield merged commit ad0661b into main Apr 16, 2024
2 checks passed
@SamDuffield SamDuffield deleted the init-fix branch April 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaqqwerty zaqqwerty zaqqwerty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamDuffield @zaqqwerty