Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut over to just using .cljc and Clojure reader conditionals #17

Merged
merged 1 commit into from
May 7, 2018

Conversation

arrdem
Copy link
Contributor

@arrdem arrdem commented Nov 18, 2017

With the introduction of reader conditionals, there isn't a particularly good reason to stay on the cljx ecosystem.

This changeset just cuts over from .cljx files to .cljc files, making use of reader conditionals where possible to maximize structural sharing between dialects.

Doesn't test cleanly on my machine due to the test case using textual rather than pattern structural equality on regexes.

running test task ["test"] ...

lein test frak-test

lein test :only frak-test/pattern-test

FAIL in (pattern-test) (frak_test.clj:59)
expected: (= "b(?:i[pt]|at)" (string-pattern ["bat" "bip" "bit"] nil))
  actual: (not (= "b(?:i[pt]|at)" "b(?:at|i[tp])"))

@noprompt
Copy link
Owner

noprompt commented May 7, 2018

@arrdem I want to apologize for letting this sit here for so long. 😭 I completely failed to see this! I really appreciate that you put this together. Merging!

@noprompt noprompt merged commit 1f203d6 into noprompt:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants