Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 新增 Lifespan.on_ready() 供适配器使用 #2483

Merged
merged 10 commits into from
Dec 10, 2023
Merged

Fix: 新增 Lifespan.on_ready() 供适配器使用 #2483

merged 10 commits into from
Dec 10, 2023

Conversation

ProgramRipper
Copy link
Member

fix #2475

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4d3cd4) 91.63% compared to head (55a89c3) 91.82%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
+ Coverage   91.63%   91.82%   +0.19%     
==========================================
  Files          47       47              
  Lines        3441     3436       -5     
==========================================
+ Hits         3153     3155       +2     
+ Misses        288      281       -7
Flag Coverage Δ
unittests 91.82% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ProgramRipper ProgramRipper mentioned this pull request Dec 5, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-2483--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 5, 2023 09:46 Inactive
@yanyongyu yanyongyu added the bug Something isn't working label Dec 6, 2023
@github-actions github-actions bot temporarily deployed to pull request December 6, 2023 07:07 Inactive
yanyongyu
yanyongyu reviewed Dec 8, 2023
View reviewed changes
tests/test_driver.py Outdated Show resolved Hide resolved
nonebot/internal/driver/_lifespan.py Outdated Show resolved Hide resolved
tests/test_driver.py Outdated Show resolved Hide resolved
@yanyongyu
Copy link
Member

另外给adapter基类添加一个 on_ready 的快捷方法吧

@github-actions github-actions bot temporarily deployed to pull request December 8, 2023 10:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 8, 2023 10:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 8, 2023 13:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 8, 2023 13:06 Inactive
@yanyongyu yanyongyu merged commit 8f3f385 into master Dec 10, 2023
27 checks passed
@yanyongyu yanyongyu deleted the fix/on-ready branch December 10, 2023 10:12
@ProgramRipper ProgramRipper changed the title Fix: 新增 Lifespan._on_ready() 供适配器使用 Fix: 新增 Lifespan.on_ready() 供适配器使用 Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanyongyu yanyongyu yanyongyu approved these changes

@he0119 he0119 Awaiting requested review from he0119

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: 使用正向连接的适配器在 NoneBot 启动完毕前处理事件
3 participants
@ProgramRipper @yanyongyu @he0119