Add cook command #133
Merged
Add cook command #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c541840
to
a7caa30
Compare
変更点
コードレビューで頂いたアドバイスを基に，コードを修正しました |
a7caa30
to
5f96bbb
Compare
lib/swimmy/command/cook.rb
Outdated
| class Cook < Swimmy::Command::Base | ||
|
|
||
| command "cook" do|client,data,match| | ||
| food = match[:expression]||"" |
There was a problem hiding this comment.
food = match[:expression] || "" のようにスペースを入れてください．
lib/swimmy/command/cook.rb
Outdated
| rakuten_app_id = ENV['RAKUTEN_COOK_ID'] | ||
| recipe_info = Service::RecipeInfomation.new.get_recipeinfo(rakuten_app_id, food) | ||
|
|
||
| if recipe_info == nil then message = "レシピが見つかりませんでした．別のキーワードで再検索してください．" |
There was a problem hiding this comment.
message = if recipe_info then recipe_info.make_mesage else "レシピが…" end と書くか，
message = recipe_info&.make_message || "レシピ…" と書けます．
lib/swimmy/resource/cook_resource.rb
Outdated
| @name, @description, @url = name, description, url | ||
| end | ||
|
|
||
| def make_message() |
There was a problem hiding this comment.
Ruby では，引数がない場合の () は不要です．
引数のコンマに空白が必要です
lib/swimmy/resource/cook_resource.rb
Outdated
| #{@url} | ||
| EOS | ||
|
|
||
| return message |
There was a problem hiding this comment.
Ruby では，途中から抜ける必要のない return は，そのまま message と書くだけでよいです
|
|
||
| class HttpException < StandardError; end | ||
|
|
||
| def get_recipeinfo(api_id, food) |
There was a problem hiding this comment.
api_id は，new の引数 (つまり initialize 関数の引数) で与えて，オブジェクト中にインスタンス変数として保持します．
| # API仕様 : https://webservice.rakuten.co.jp/documentation/recipe-category-list | ||
| result = JSON.parse(URI.open(category_url, &:read)) | ||
| rescue | ||
| puts "HttpException\n" |
There was a problem hiding this comment.
これでは，情報量がありません．もともと rescue した例外の詳細を puts して log に吐くべきです．
| # API仕様 : https://webservice.rakuten.co.jp/documentation/recipe-category-ranking | ||
| recipe_ranking = JSON.parse(URI.open(ranking_url, &:read)) | ||
| rescue | ||
| puts "HttpException\n" |
There was a problem hiding this comment.
これでは，情報量がありません．もともと rescue した例外の詳細を puts して log に吐くべきです．
lib/swimmy/command/cook.rb
Outdated
| module Command | ||
| class Cook < Swimmy::Command::Base | ||
|
|
||
| command "cook" do|client,data,match| |
There was a problem hiding this comment.
以降同様ですが，コンマや演算子の前後にスペースを入れてください．
lib/swimmy/command/cook.rb
Outdated
|
|
||
| if recipe_info == nil then message = "レシピが見つかりませんでした．別のキーワードで再検索してください．" | ||
| else | ||
| message = recipe_info.make_message() |
Comment on lines
71
to
132
| result["result"]["large"].each do |list| | ||
| category_id_list[list["categoryName"]] = list["categoryId"].to_s | ||
| end | ||
| result["result"]["medium"].each do |list| | ||
| category_id_list[list["categoryName"]] = list["parentCategoryId"].to_s + "-" + list["categoryId"].to_s | ||
| parent_id_list[list["categoryId"]] = list["parentCategoryId"] | ||
| end | ||
| result["result"]["small"].each do |list| | ||
| parent_id = parent_id_list[list["parentCategoryId"].to_i] | ||
| category_id_list[list["categoryName"]] = parent_id + "-" + list["parentCategoryId"].to_s + "-" + list["categoryId"].to_s | ||
| end |
There was a problem hiding this comment.
これらが何をやっているのかコメントを付けてください．
5f96bbb
to
62cd6c2
Compare
|
頂いたレビューコメントを基に，コードを修正しました． 共通の修正点
cook.rb の修正点
cook_resource.rb の修正点
recipe_information の修正点
|
| end | ||
|
|
||
| private | ||
| def get_reciperanking(food, category_id_hash) |
There was a problem hiding this comment.
get_receiperanking → get_receipe_ranking がいいと思います．
| p e | ||
| raise HttpException.new | ||
| end | ||
|
|
| client.say(channel: data.channel, text: "レシピ情報を取得しています……") | ||
|
|
||
| begin | ||
| rakuten_app_id = ENV['RAKUTEN_COOK_ID'] |
There was a problem hiding this comment.
環境変数 RAKUTEN_COOK_ID が設定されていなかった場合の分岐を考えてください．
また，food の設定と RAKUTEN_COOK_ID の設定が離れているので，順序やタイミングを調整したほうがいいです．begin ... rescue に入れるべきかどうかの検討も含めて．
|
|
||
| private | ||
| def get_reciperanking(food, category_id_hash) | ||
| recipe_candidates = category_id_hash.find_all{|key,value| key.include?(food)} |
There was a problem hiding this comment.
key,value → key, value
62cd6c2
to
26f4261
Compare
|
頂いたレビューコメントを基に，コードを修正しました． cook.rb の修正点
recipe_information の修正点
|
26f4261
to
c5781be
Compare
|
検討打合せでいただいたレビューを基にPRを更新しました．
|
c5781be
to
c5aac15
Compare
|
談話会でいただいたレビューを基にPRを更新しました．
|
f423062
to
fdee2d1
Compare
fdee2d1
to
649d548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
cook コマンドの追加
コマンドの概要
機能
指定された食材や料理に適したレシピの情報を表示する．
使用方法
swimmy cook <キーワード>と入力するとキーワードに適したレシピを表示する．swimmy cookと入力するとランダムにレシピを表示する．特徴
楽天レシピカテゴリ一覧APIと楽天レシピカテゴリ別ランキングAPIを使用している．