Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never return None in ooxml's _parseinfo #88

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

gdesmar
Copy link
Contributor

@gdesmar gdesmar commented May 1, 2024

In the case where we are handling a corrupted file, the EncryptionInfo could be versionMajor 0 and versionMinor 0. In that case, the code ends up returning None, which then tries to get unpacked into two objects for self.type and self.info. By always throwing and exception, it should cover the case where the code doesn't handle the specified EncryptionInfo version.

@nolze
Copy link
Owner

nolze commented May 2, 2024

Thanks! Much appreciated.

@nolze nolze merged commit c5abf6a into nolze:master May 2, 2024
14 checks passed
@nolze nolze removed the in progress label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants