Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RC4CryptoAPI_makekey #48

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Conversation

doracpphp
Copy link
Contributor

Hello!

https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-offcrypto/12ec1195-af2d-44e6-8c73-003e79e635d5
keyLength is exactly 40 bits, the encryption key MUST be composed of the first 40 bits of Hfinal and 88 bits set to zero, creating a 128-bit key.

https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-offcrypto/12ec1195-af2d-44e6-8c73-003e79e635d5
keyLength is exactly 40 bits, the encryption key MUST be composed of the first 40 bits of Hfinal and 88 bits set to zero, creating a 128-bit key.
@nolze nolze self-requested a review April 7, 2020 12:12
@codecov-io
Copy link

codecov-io commented Apr 7, 2020

Codecov Report

Merging #48 into master will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   86.64%   86.59%   -0.06%     
==========================================
  Files          13       13              
  Lines        1168     1171       +3     
==========================================
+ Hits         1012     1014       +2     
- Misses        156      157       +1     
Impacted Files Coverage Δ
msoffcrypto/method/rc4_cryptoapi.py 95.23% <50.00%> (ø)
msoffcrypto/format/ppt97.py 98.62% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d1d0e...1ce0039. Read the comment docs.

Copy link
Owner

@nolze nolze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I made a small change in style.

@nolze nolze merged commit 18418f6 into nolze:master Apr 7, 2020
@nolze nolze removed the in progress label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants