-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "verify_passwd" and "verify_integrity" option #46
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
- Coverage 86.64% 84.7% -1.94%
=========================================
Files 13 13
Lines 1168 1223 +55
=========================================
+ Hits 1012 1036 +24
- Misses 156 187 +31
Continue to review full report at Codecov.
|
Thanks! Overall it looks good to me. I'll take time to review and suggest some minor changes within 1-2 weeks. |
Sorry for taking time to look into this; please wait a little while. |
Never mind, please take your time! |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 86.64% 87.00% +0.36%
==========================================
Files 13 13
Lines 1168 1224 +56
==========================================
+ Hits 1012 1065 +53
- Misses 156 159 +3
Continue to review full report at Codecov.
|
Finally I'm happy to get ready to merge your PR. I added some changes, especially to
EDIT: To put your name in the contributors page, please match the email address added in your GitHub account and ones used in your commits. |
Your changes look nice to me. I will also check my email and let you know. |
I updated my email to the correct one. If you do not have other issues, please accept the PR. To keep track of what I did:
I hope that I did it correctly. Interestingly GitHub updates the PR automatically so I do not need to file a new one. |
Looks good to me. Thank you for your patience and cooperation! |
#45