Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify setup.py name with package name #29

Closed

Conversation

christian-intra2net
Copy link
Contributor

It is unusual for name and package name to be different. This complicates building rpms, for example.

It is unusual for name and package name to be different. This complicates
building rpms, for example.
@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   36.68%   36.68%           
=======================================
  Files          13       13           
  Lines        1145     1145           
=======================================
  Hits          420      420           
  Misses        725      725

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8689b89...34dc687. Read the comment docs.

@nolze
Copy link
Owner

nolze commented Apr 4, 2019

Thank you for PR!

I totally agree that it would be better if we had the single name, but now I consider it is virtually impossible for several reasons:

I feel our situation is tolerable, as some well-known packages are named doubly as well. (e.g. scikit-learn and sklearn)
Please comment or open an issue if more detailed consideration is required.

@christian-intra2net
Copy link
Contributor Author

Ok, those are valid reasons. Then we will have to live with it, I guess.

@nolze nolze removed the in progress label Apr 9, 2019
@christian-intra2net christian-intra2net deleted the name-remove-tool branch April 30, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants