doc97: Decrypt the `Data' stream as well. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 41.52% 40.94% -0.59%
==========================================
Files 12 12
Lines 773 784 +11
==========================================
Hits 321 321
- Misses 452 463 +11
Continue to review full report at Codecov.
|
According to the official documentation [1], the `Data' stream must be encrypted and thus, decrypted as well. I tried with a doc file with lots of pictures, when the `Data' stream is not decrypted, complaint about corrupted data is made, and none of the pictures could be viewed, on the other hand everything works fine if it's fully decrypted. [1] https://msdn.microsoft.com/en-us/library/dd945648(v=office.12).aspx https://msdn.microsoft.com/en-us/library/dd946845(v=office.12).aspx
|
Thank you! We haven't tested that case. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the official documentation [1], the Data stream must be
encrypted and thus, decrypted as well. I tried with a doc file with
lots of pictures, when the Data stream is not decrypted, complaint
about corrupted data is made, and none of the pictures could be
viewed, on the other hand everything works fine if it's fully decrypted.
[1] https://msdn.microsoft.com/en-us/library/dd945648(v=office.12).aspx
https://msdn.microsoft.com/en-us/library/dd946845(v=office.12).aspx