Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to test if xls97 is encrypted #11

Merged
merged 4 commits into from
Aug 21, 2018
Merged

Added ability to test if xls97 is encrypted #11

merged 4 commits into from
Aug 21, 2018

Conversation

NPDW
Copy link
Contributor

@NPDW NPDW commented Aug 16, 2018

Added ability to test if xls97 is encrypted. Refactored the is_encrypted to be more class-based. Also slightly refactored Xls97File to be more similar to Doc97File

…ted to be more class-based. Also slightly refactored Xls97File to be more similar to Doc97File
@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #11 into master will decrease coverage by 0.37%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   34.37%   33.99%   -0.38%     
==========================================
  Files          12       12              
  Lines         736      753      +17     
==========================================
+ Hits          253      256       +3     
- Misses        483      497      +14
Impacted Files Coverage Δ
msoffcrypto/__main__.py 0% <0%> (ø) ⬆️
msoffcrypto/format/doc97.py 31.96% <50%> (+0.16%) ⬆️
msoffcrypto/format/ooxml.py 50.53% <50%> (-0.02%) ⬇️
msoffcrypto/format/xls97.py 15.06% <6.25%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e615e2...ff2376b. Read the comment docs.

@nolze
Copy link
Owner

nolze commented Aug 18, 2018

Thanks!

I added minor changes after your commits:

  • As _BIFFStream class I imlemented is quite an ad-hoc utility at present, I'd prefer to keep it for internal use only. We'll be able to make a better one in future.
  • Seek Xls97File's data.workbook stream to zero before each use.
  • Bump version to 4.6.0 by introducing is_encrypted() method.

I'll merge this PR in a few days. Please let me know if you have any thoughts.

@nolze nolze merged commit 934e188 into nolze:master Aug 21, 2018
@nolze nolze removed the in progress label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants