Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Password ability #1

Merged
merged 9 commits into from
May 3, 2017
Merged

Addition of Password ability #1

merged 9 commits into from
May 3, 2017

Conversation

dsplice
Copy link

@dsplice dsplice commented May 2, 2017

This pull request includes the ability of using plaintext password to decrypt the document.

@nolze nolze merged commit e574767 into nolze:master May 3, 2017
@nolze
Copy link
Owner

nolze commented May 3, 2017

Thanks! This is the very essential feature.

I made some additional fixes, testing with some Office 2016 documents at hand. Does it work well for yours, too?

I'm going to add tests and do some refactoring soon.

@dsplice
Copy link
Author

dsplice commented May 3, 2017 via email

@nolze
Copy link
Owner

nolze commented May 7, 2018

Hi @dsplice, I noticed that your name is missing from the contributors page of this repository.
I guess your email address with which you made the commits is different from the one(s) associated with your GitHub account (I don't put the email address here, but you can check it by cloning this repo and doing git log).

If you don't mind, please add the email address (in git log) to your GitHub account; it would be nice to see you on the contributors page :)

@dsplice
Copy link
Author

dsplice commented May 7, 2018

Forgot I used my work email for that one. Added! And thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants