Fix position issues caused by calculateHeight: true #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues 254, 258 and probably 283 --- When calculateHeight is true, containerSize was set to the calculated height, rather than the width. I refactored the code to avoid the double assignment and assign containerSize to height, only for vertical mode (!isH)
|
Brilliant! This is exactly what I just posted about a moment ago. Thanks, dogoku. |
|
great minds think alike? :P |
|
Yes, only my great mind wasted 12 hours trying to figure it out =P |
|
Merged, thanks guys! |
nolimits4web
added a commit
that referenced
this pull request
Aug 7, 2013
Fix position issues caused by calculateHeight: true
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #254, #258 and probably #283
When
calculateHeightis true,containerSizewas set to the calculated height, rather than the width.I refactored the code to avoid the double assignment and assign
containerSizeto height, only for vertical mode (!isH)