Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): add parser buffer reallocation case #703

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Apr 8, 2021

Ref #438

@ronag ronag merged commit 84ae945 into main Apr 8, 2021
@@ -1063,3 +1063,38 @@ test('emit disconnect after destory', t => {
})
})
})

test('parser dinamic allocation', { only: true }, t => {
t.plan(3)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go deeper and actually check the parser bufferSize property?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't think that is necessary. But, wouldn't hurt either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it in #704

@ronag ronag deleted the more_parser_coverage branch April 8, 2021 12:09
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants