fix(parser): safer get_error_reason #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the returned pointer is valid befire retrieving the error message.
ronag
reviewed
Apr 7, 2021
ronag
approved these changes
Apr 7, 2021
Check for truthy instead of zero in `get_error_reason` Co-authored-by: Robert Nagy <[email protected]>
8617eca
to
306eb80
Compare
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix(parser): safer get_error_reason Check that the returned pointer is valid befire retrieving the error message. * fix(parser): update pointer check in execute Check for truthy instead of zero in `get_error_reason` Co-authored-by: Robert Nagy <[email protected]> Co-authored-by: Robert Nagy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the returned pointer is valid befire retrieving the error
message.
Fixes #684