Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage badge #483

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Coverage badge #483

merged 2 commits into from
Nov 18, 2020

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Nov 18, 2020 •
edited
Loading

  • setup codecov coverage report in CI workflow
  • add coverage badge in README

Fixes #397

There is no custom configuration setup using codecov.yml file, I don't see anything we could add ATM. The config reference:

https://docs.codecov.io/docs/codecov-yaml

mcollina
mcollina approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 7ea4c55 into nodejs:master Nov 18, 2020
@dnlup dnlup deleted the coverage_badge branch November 20, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coverage badge
3 participants
@dnlup @mcollina @ronag