Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node 12.9 #449

Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix: node 12.9 #449

merged 1 commit into from
Oct 7, 2020

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 7, 2020

No description provided.

@ronag ronag requested a review from mcollina October 7, 2020 15:25
mcollina
mcollina approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it would be good to have a test for this

@ronag
Copy link
Member Author

ronag commented Oct 7, 2020

Existing tests fail with node 12.9

@ronag ronag merged commit 6c2da70 into master Oct 7, 2020
ronag added a commit that referenced this pull request Oct 9, 2020
@ronag
fix: node 12.9 (#449)
05b782c 
Fixes: #448
@Jolg42 Jolg42 mentioned this pull request Oct 9, 2020
Closed
@ronag ronag mentioned this pull request Oct 10, 2020
Closed
@Uzlopak Uzlopak deleted the fix-12 branch February 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @mcollina