fix: close() deadlock #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
When no resume is going to be scheduled, request.onError might never be detected. Fixes: #344
ronag
added
the
semver-major
ronag
force-pushed
the
close-deadlock
branch
9 times, most recently
from
d1f6423
to
596eca7
Compare
ronag
force-pushed
the
close-deadlock
branch
4 times, most recently
from
9ff2abb
to
d1dfee2
Compare
|
Some todos and tests remain to be sorted. I'll look into those if this gets preliminary approval. |
ronag
force-pushed
the
close-deadlock
branch
3 times, most recently
from
48c3059
to
61eda9a
Compare
ronag
commented
Aug 20, 2020
ronag
commented
Aug 20, 2020
ronag
force-pushed
the
close-deadlock
branch
6 times, most recently
from
67c3e7d
to
ea4dad6
Compare
This comment has been minimized.
This comment has been minimized.
ronag
force-pushed
the
close-deadlock
branch
14 times, most recently
from
c24af1a
to
c9395eb
Compare
|
Really good work @ronag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no resume is going to be scheduled, request.onError might never be detected or in the case of
Client.pipelinethe stream destroy.See test case in first commit, adb4fae.
Fixes: #344
There is a problem with the existing API where if a running request is aborted while the server is not providing any data nothing is ticking the state machine.
There are some API changes:
A new hook is added on dispatch handler,
onConnect(abort).onDatanow only returns a boolean (no magicalnull).