Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make some test run even without internet connection #2786

Merged
merged 3 commits into from
Feb 20, 2024
Merged

chore: make some test run even without internet connection #2786

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3960832
chore: reduce necessity of internet connection for test
Uzlopak Feb 20, 2024
f9679cc
fix wrong description of test
Uzlopak Feb 20, 2024
2b5d783
make connect-timeout test work when no internet connection
Uzlopak Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make connect-timeout test work when no internet connection
  • Loading branch information
@Uzlopak
Uzlopak committed Feb 20, 2024
commit 2b5d7830fbe114a349b9ad3701e8af57f36b9f8a
2 changes: 1 addition & 1 deletion test/connect-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('prioritize socket errors over timeouts', () => {
client.request({ method: 'GET', path: '/foobar' })
.then(() => t.fail())
.catch((err) => {
t.strictEqual(err.code, 'ENOTFOUND')
t.strictEqual(['ENOTFOUND', 'EAI_AGAIN'].includes(err.code), true)
})

// block for 1s which is enough for the dns lookup to complete and TO to fire
Expand Down
Loading