perf(util): improve isFormDataLike checks #1875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would implement #1872.
Context
Actually, the
FormData
class needs the following declaration to work:The
isFormDataLike
method was improved by checking theconstructor.name
and the declaration of those methods. This makes that control more strict and flexible. The check would be linear, there is no way to guess what API is requested by thechunk
. This check allows third-party libraries to be compatible with this control.Tests
The tests were updated by adding some cases where the check should return false or true.