Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autobahn workflow is always 1 commit behind #3289

Closed
KhafraDev opened this issue May 21, 2024 · 1 comment · Fixed by #3291
Closed

autobahn workflow is always 1 commit behind #3289

KhafraDev opened this issue May 21, 2024 · 1 comment · Fixed by #3291
Labels
bug Something isn't working

Comments

@KhafraDev
Copy link
Member

https://github.com/nodejs/undici/blob/main/.github/workflows/autobahn.yml

@Uzlopak
@KhafraDev KhafraDev added the bug Something isn't working label May 21, 2024
@Uzlopak
Copy link
Contributor

Uzlopak commented May 21, 2024

I will implement it in few hours.

KhafraDev added a commit to KhafraDev/undici that referenced this issue May 21, 2024
@KhafraDev
revert: "websocket: pre-calculated length"
362067a 
This reverts 13523fd which broke
permessage-deflate support.

See nodejs#3289 for why the tests did
not catch this.
This was referenced May 21, 2024
Merged
Merged
KhafraDev added a commit to KhafraDev/undici that referenced this issue May 21, 2024
@KhafraDev
revert: "websocket: pre-calculated length"
a1805af 
This reverts 13523fd which broke
permessage-deflate support.

See nodejs#3289 for why the tests did
not catch this.
KhafraDev added a commit that referenced this issue May 21, 2024
@KhafraDev
revert: "websocket: pre-calculated length" (#3290)
fcfa4db 
* revert: "websocket: pre-calculated length"

This reverts 13523fd which broke
permessage-deflate support.

See #3289 for why the tests did
not catch this.

* rerun autobahn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix autobahn workflow Uzlopak/undici
2 participants
@Uzlopak @KhafraDev