Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP 100 Continue #197

Open
ronag opened this issue May 26, 2020 · 9 comments
Open

HTTP 100 Continue #197

ronag opened this issue May 26, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@ronag
Copy link
Member

ronag commented May 26, 2020 •
edited
Loading

https://tools.ietf.org/html/rfc7231#section-6.2.1
@ronag ronag added the enhancement New feature or request label May 26, 2020
@ronag ronag modified the milestone: Next Release May 26, 2020
@ronag
Copy link
Member Author

ronag commented May 26, 2020

Nice to have. I suppose 100 Continue is a bit of an optimization not frequently used. Probably fine to not support.

ronag added a commit that referenced this issue Aug 1, 2020
@ronag
feat: onInfo & onTrailers options
a6990ab 
Fixes: #179
Fixes: #197
Fixes: #196
ronag added a commit that referenced this issue Aug 1, 2020
@ronag
feat: onInfo & onTrailers options
b4bba09 
Fixes: #179
Fixes: #197
Fixes: #196
ronag added a commit that referenced this issue Aug 1, 2020
@ronag
feat: onInfo & onTrailers options
a179b17 
Fixes: #179
Fixes: #197
Fixes: #196
ronag added a commit that referenced this issue Aug 1, 2020
@ronag
feat: onInfo & onTrailers options
62e056c 
Fixes: #179
Fixes: #197
Fixes: #196
@ronag
Copy link
Member Author

ronag commented Aug 1, 2020

@mcollina @szmarczak is this even worth implementing? Does anyone use it as far you know?

@mcollina
Copy link
Member

mcollina commented Aug 1, 2020

No one that I know of.

@szmarczak
Copy link
Member

Me neither. I'd say let's ignore 100, it doesn't change anything.

@ronag
Copy link
Member Author

ronag commented Aug 1, 2020

Should we throw on expect 100 header?

@szmarczak
Copy link
Member

I think so. If this becomes an issue (but I don't think it will) then we can add 100 support later.

@ronag ronag added the Status: wontfix This will not be worked on label Aug 9, 2020
@ronag ronag closed this as completed Aug 9, 2020
@ronag
Copy link
Member Author

ronag commented Feb 20, 2021 •
edited
Loading

I have found a use case where I miss this. When having multiple upstream servers where one might be full a reverse proxy should be able to pick another one without losing payload.

@ronag ronag reopened this Feb 20, 2021
@trivikr
Copy link
Member

trivikr commented May 10, 2021

I have found a use case where I miss this. When having multiple upstream servers where one might be full a reverse proxy should be able to pick another one without losing payload.

Should Status: wontfix label be removed if the work to add HTTP 100 Continue is going to be prioritized?

@mcollina mcollina removed the Status: wontfix This will not be worked on label May 10, 2021
@mcollina
Copy link
Member

Our priority right know is bugfixing for the v4 release. If you would like to work on it, PRs are always welcome.

nandi95 added a commit to upfrontjs/framework that referenced this issue Apr 12, 2024
@nandi95
test: remove test with 100 status
ca26449 
nodejs/undici#197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @ronag @trivikr @szmarczak