fix: no _ prefix for dispatch methods

nodejs · Aug 12, 2020 · 8703ee5 · 8703ee5
1 parent 767e406
commit 8703ee5
Show file tree

Hide file tree

Showing 8 changed files with 30 additions and 30 deletions.
diff --git a/benchmarks/index.js b/benchmarks/index.js
@@ -152,15 +152,15 @@ class NoopRequest {
  this.deferred = deferred
  }
 
- _onHeaders () {
+ onHeaders () {
 
  }
 
- _onData (chunk) {
+ onData (chunk) {
  return true
  }
 
- _onComplete (trailers) {
+ onComplete (trailers) {
  this.deferred.resolve()
  }
 }
@@ -170,15 +170,15 @@ class SimpleRequest {
  this.dst = dst
  }
 
- _onHeaders (statusCode, headers, resume) {
+ onHeaders (statusCode, headers, resume) {
  this.dst.on('drain', resume)
  }
 
- _onData (chunk) {
+ onData (chunk) {
  return this.dst.write(chunk)
  }
 
- _onComplete () {
+ onComplete () {
  this.dst.end()
  }
 }
diff --git a/lib/client-connect.js b/lib/client-connect.js
@@ -10,7 +10,7 @@ class ConnectRequest {
  this.callback = callback
  }
 
- _onUpgrade (statusCode, headers, socket) {
+ onUpgrade (statusCode, headers, socket) {
  const { callback, opaque } = this
 
  this.callback = null
@@ -22,7 +22,7 @@ class ConnectRequest {
  })
  }
 
- _onError (err) {
+ onError (err) {
  const { callback, opaque } = this
 
  this.callback = null

diff --git a/lib/client-pipeline.js b/lib/client-pipeline.js
@@ -110,7 +110,7 @@ class PipelineHandler extends AsyncResource {
  this.res = null
  }
 
- _onHeaders (statusCode, headers, resume) {
+ onHeaders (statusCode, headers, resume) {
  const { opaque, handler, ret } = this
 
  if (statusCode < 200) {
@@ -171,7 +171,7 @@ class PipelineHandler extends AsyncResource {
  this.body = body
  }
 
- _onData (chunk) {
+ onData (chunk) {
  const { res } = this
 
  if (res._readableState.destroyed) {
@@ -181,7 +181,7 @@ class PipelineHandler extends AsyncResource {
  return res.push(chunk)
  }
 
- _onComplete (trailers) {
+ onComplete (trailers) {
  const { res } = this
 
  if (res._readableState.destroyed) {
@@ -191,7 +191,7 @@ class PipelineHandler extends AsyncResource {
  res.push(null)
  }
 
- _onError (err) {
+ onError (err) {
  const { ret } = this
 
  this.handler = null

diff --git a/lib/client-request.js b/lib/client-request.js
@@ -33,7 +33,7 @@ class RequestHandler extends AsyncResource {
  this.res = null
  }
 
- _onHeaders (statusCode, headers, resume) {
+ onHeaders (statusCode, headers, resume) {
  const { callback, opaque } = this
 
  if (statusCode < 200) {
@@ -53,7 +53,7 @@ class RequestHandler extends AsyncResource {
  })
  }
 
- _onData (chunk) {
+ onData (chunk) {
  const { res } = this
 
  if (res._readableState.destroyed) {
@@ -63,7 +63,7 @@ class RequestHandler extends AsyncResource {
  return res.push(chunk)
  }
 
- _onComplete (trailers) {
+ onComplete (trailers) {
  const { res } = this
 
  if (res._readableState.destroyed) {
@@ -73,7 +73,7 @@ class RequestHandler extends AsyncResource {
  res.push(null)
  }
 
- _onError (err) {
+ onError (err) {
  const { res, callback, opaque } = this
 
  if (callback) {

diff --git a/lib/client-stream.js b/lib/client-stream.js
@@ -19,7 +19,7 @@ class StreamHandler extends AsyncResource {
  this.trailers = null
  }
 
- _onHeaders (statusCode, headers, resume) {
+ onHeaders (statusCode, headers, resume) {
  const { factory, callback, opaque } = this
 
  if (statusCode < 200) {
@@ -66,7 +66,7 @@ class StreamHandler extends AsyncResource {
  this.res = res
  }
 
- _onData (chunk) {
+ onData (chunk) {
  const { res } = this
 
  if (util.isDestroyed(res)) {
@@ -76,7 +76,7 @@ class StreamHandler extends AsyncResource {
  return res.write(chunk)
  }
 
- _onComplete (trailers) {
+ onComplete (trailers) {
  const { res } = this
 
  if (util.isDestroyed(res)) {
@@ -88,7 +88,7 @@ class StreamHandler extends AsyncResource {
  res.end()
  }
 
- _onError (err) {
+ onError (err) {
  const { res, callback, opaque } = this
 
  this.factory = null

diff --git a/lib/client-upgrade.js b/lib/client-upgrade.js
@@ -10,7 +10,7 @@ class UpgradeHandler {
  this.callback = callback
  }
 
- _onUpgrade (statusCode, headers, socket) {
+ onUpgrade (statusCode, headers, socket) {
  const { callback, opaque } = this
 
  this.callback = null
@@ -21,7 +21,7 @@ class UpgradeHandler {
  })
  }
 
- _onError (err) {
+ onError (err) {
  const { callback, opaque } = this
 
  this.callback = null

diff --git a/lib/request.js b/lib/request.js
@@ -197,7 +197,7 @@ class Request {
 
  reset.call(this)
 
- this[kHandler]._onUpgrade(statusCode, headers, socket)
+ this[kHandler].onUpgrade(statusCode, headers, socket)
  }
 
  onHeaders (statusCode, headers, resume) {
@@ -218,7 +218,7 @@ class Request {
  clearTimeout(timeout)
  }
 
- this[kHandler]._onHeaders(statusCode, headers, resume)
+ this[kHandler].onHeaders(statusCode, headers, resume)
  }
 
  onBody (chunk, offset, length) {
@@ -228,7 +228,7 @@ class Request {
  return
  }
 
- return this[kHandler]._onData(chunk.slice(offset, offset + length))
+ return this[kHandler].onData(chunk.slice(offset, offset + length))
  }
 
  onComplete (trailers) {
@@ -240,7 +240,7 @@ class Request {
 
  reset.call(this)
 
- return this[kHandler]._onComplete(trailers)
+ return this[kHandler].onComplete(trailers)
  }
 
  onError (err) {
@@ -261,7 +261,7 @@ class Request {
  }
 
  process.nextTick((handler, err) => {
- handler._onError(err)
+ handler.onError(err)
  }, this[kHandler], err)
  }
 }

diff --git a/test/pool.js b/test/pool.js
@@ -414,13 +414,13 @@ test('pool dispatch', (t) => {
  path: '/',
  method: 'GET'
  }, {
- _onHeaders (statusCode, headers) {
+ onHeaders (statusCode, headers) {
  t.strictEqual(statusCode, 200)
  },
- _onData (chunk) {
+ onData (chunk) {
  buf += chunk
  },
- _onComplete () {
+ onComplete () {
  t.strictEqual(buf, 'asd')
  }
  })