feat: allow pausing from onHeaders

nodejs · Oct 11, 2020 · 4ae8b9d · 4ae8b9d
1 parent b1ba471
commit 4ae8b9d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -473,7 +473,7 @@ The `handler` parameter is defined as follow:
  * `statusCode: Number`
  * `headers: Array|Null`
  * `socket: Duplex`
-* `onHeaders(statusCode, headers, resume): Void`, invoked when statusCode and headers have been received.
+* `onHeaders(statusCode, headers, resume): Boolean`, invoked when statusCode and headers have been received.
  May be invoked multiple times due to 1xx informational headers.
  * `statusCode: Number`
  * `headers: Array|Null`, an array of key-value pairs. Keys are not automatically lowercased.

diff --git a/lib/core/client.js b/lib/core/client.js
@@ -542,7 +542,9 @@ class Parser extends HTTPParser {
  }
 
  try {
- request.onHeaders(statusCode, headers, statusCode < 200 ? null : socket[kResume])
+ if (request.onHeaders(statusCode, headers, statusCode < 200 ? null : socket[kResume]) === false) {
+ socket[kPause]()
+ }
  } catch (err) {
  util.destroy(socket, err)
  return 1

diff --git a/lib/core/request.js b/lib/core/request.js
@@ -117,7 +117,7 @@ class Request {
 
  clearRequestTimeout(this)
 
- this[kHandler].onHeaders(statusCode, headers, resume)
+ return this[kHandler].onHeaders(statusCode, headers, resume)
  }
 
  onBody (chunk, offset, length) {