fix: free parser when detaching

nodejs · Oct 25, 2020 · 1dc8328 · 1dc8328
1 parent e0f33a8
commit 1dc8328
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/core/client.js b/lib/core/client.js
@@ -651,6 +651,11 @@ class Parser extends HTTPParser {
  resume(client)
  }
  }
+
+ destroy () {
+ this.unconsume()
+ setImmediate((self) => self.close(), this)
+ }
 }
 
 function onSocketConnect () {
@@ -705,8 +710,7 @@ function onSocketClose () {
 
  client[kSocket] = null
 
- parser.unconsume()
- setImmediate(() => parser.close())
+ parser.destroy()
 
  if (err.code !== 'UND_ERR_INFO') {
  // Evict session on errors.
@@ -744,10 +748,11 @@ function onSocketSession (session) {
 }
 
 function detachSocket (socket) {
+ socket[kParser].destroy()
+ socket[kParser] = null
  socket[kPause] = null
  socket[kResume] = null
  socket[kClient] = null
- socket[kParser] = null
  socket[kError] = null
  socket
  .removeListener('timeout', onSocketTimeout)