test_runner: add jsdocs to MockTimers #49476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Signed-off-by: Erick Wendel <[email protected]>
8767073
to
de65b28
Compare
|
Fast-track has been requested by @ErickWendel. Please 👍 to approve. |
atlowChemi
reviewed
Sep 4, 2023
benjamingr
approved these changes
Sep 4, 2023
Co-authored-by: Benjamin Gruenbaum <[email protected]> Co-authored-by: Chemi Atlow <[email protected]>
atlowChemi
approved these changes
Sep 4, 2023
benjamingr
approved these changes
Sep 4, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49476
✘ Failed to get collaborator info from nodejs/node/README.md
Error: Couldn't find ### TSC (Technical Steering Committee) in the README
at parseCollaborators (file:https:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:81:11)
at getCollaborators (file:https:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:59:21)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async PRData.getCollaborators (file:https:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:74:26)
at async Promise.all (index 0)
at async PRData.getAll (file:https:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:58:5)
at async getMetadata (file:https:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/components/metadata.js:18:3)
at async main (file:https:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/components/git/land.js:204:22)https://github.com/nodejs/node/actions/runs/6079853604 |
Commit Queue failed- Loading data for nodejs/node/pull/49476 ✔ Done loading data for nodejs/node/pull/49476 ----------------------------------- PR info ------------------------------------ Title test_runner: add jsdocs to MockTimers (#49476) Author Erick Wendel (@ErickWendel) Branch ErickWendel:test_runner/add-js-docs-to-mock -> nodejs:main Labels fast-track, needs-ci, commit-queue-squash, test_runner Commits 2 - test_runner: add jsdocs to MockTimers - test_runner: apply suggestions Committers 2 - Erick Wendel - GitHub PR-URL: https://github.com/nodejs/node/pull/49476 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Chemi Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49476 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Chemi Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 03 Sep 2023 21:04:58 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49476#pullrequestreview-1609950368 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49476#pullrequestreview-1609909238 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6081106699 |
|
Landed in f139cc3 |
This was referenced Sep 6, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
Signed-off-by: Erick Wendel <[email protected]> PR-URL: #49476 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Signed-off-by: Erick Wendel <[email protected]> PR-URL: nodejs#49476 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Erick Wendel <[email protected]> PR-URL: #49476 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Erick Wendel <[email protected]> PR-URL: nodejs/node#49476 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Erick Wendel <[email protected]> PR-URL: nodejs/node#49476 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JSDocs for all public functions on MockTimers
cc @nodejs/test_runner