esm: unflag import.meta.resolve

doc/api/cli.md

@@ -512,9 +512,18 @@ of `--enable-source-maps`.
 added:
  - v13.9.0
  - v12.16.2
+changes:
+ - version: X.X.X
+ pr-url: incoming
+ description: synchronous import.meta.resolve made available by default, with
+ the flag retained for enabling the experimental second argument
+ as previously supported.
 -->
 
-Enable experimental `import.meta.resolve()` support.
+Enable experimental `import.meta.resolve()` parent URL support, which allows
+passing a second `parentURL` argument for contextual resolution.
+
+Previously gated the entire `import.meta.resolve` feature.
 
 ### `--experimental-loader=module`
 

lib/internal/modules/esm/initialize_import_meta.js

@@ -7,11 +7,14 @@ const experimentalImportMetaResolve = getOptionValue('--experimental-import-meta
  * Generate a function to be used as import.meta.resolve for a particular module.
  * @param {string} defaultParentURL The default base to use for resolution
  * @param {typeof import('./loader.js').ModuleLoader} loader Reference to the current module loader
+ * @param {bool} allowParentURL Whether to permit parentURL second argument for contextual resolution
  * @returns {(specifier: string, parentURL?: string) => string} Function to assign to import.meta.resolve
  */
-function createImportMetaResolve(defaultParentURL, loader) {
- return function resolve(specifier, parentURL = defaultParentURL) {
+function createImportMetaResolve(defaultParentURL, loader, allowParentURL) {
+ return function resolve(specifier) {
  let url;
+ const parentURL = allowParentURL ? arguments[1] ?? defaultParentURL : defaultParentURL;
+
  try {
  ({ url } = loader.resolveSync(specifier, parentURL));
  return url;
@@ -40,8 +43,8 @@ function initializeImportMeta(meta, context, loader) {
  const { url } = context;
 
  // Alphabetical
- if (experimentalImportMetaResolve && loader.allowImportMetaResolve) {
- meta.resolve = createImportMetaResolve(url, loader);
+ if (!loader || loader.allowImportMetaResolve) {
+ meta.resolve = createImportMetaResolve(url, loader, experimentalImportMetaResolve);
  }
 
  meta.url = url;

src/node_options.cc

@@ -396,7 +396,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
  &EnvironmentOptions::experimental_wasm_modules,
  kAllowedInEnvvar);
  AddOption("--experimental-import-meta-resolve",
- "experimental ES Module import.meta.resolve() support",
+ "experimental ES Module import.meta.resolve() parentURL support",
  &EnvironmentOptions::experimental_import_meta_resolve,
  kAllowedInEnvvar);
  AddOption("--experimental-permission",

test/es-module/test-esm-import-meta-resolve.mjs

@@ -41,7 +41,6 @@ assert.strictEqual(import.meta.resolve('baz/', fixtures),
 
 {
  const cp = spawn(execPath, [
- '--experimental-import-meta-resolve',
  '--input-type=module',
  '--eval', 'console.log(typeof import.meta.resolve)',
  ]);
@@ -50,7 +49,6 @@ assert.strictEqual(import.meta.resolve('baz/', fixtures),
 
 {
  const cp = spawn(execPath, [
- '--experimental-import-meta-resolve',
  '--input-type=module',
  ]);
  cp.stdin.end('console.log(typeof import.meta.resolve)');
@@ -59,7 +57,6 @@ assert.strictEqual(import.meta.resolve('baz/', fixtures),
 
 {
  const cp = spawn(execPath, [
- '--experimental-import-meta-resolve',
  '--input-type=module',
  '--eval', 'import "data:text/javascript,console.log(import.meta.resolve(%22node:os%22))"',
  ]);
@@ -68,7 +65,6 @@ assert.strictEqual(import.meta.resolve('baz/', fixtures),
 
 {
  const cp = spawn(execPath, [
- '--experimental-import-meta-resolve',
  '--input-type=module',
  ]);
  cp.stdin.end('import "data:text/javascript,console.log(import.meta.resolve(%22node:os%22))"');

test/es-module/test-esm-import-meta.mjs

@@ -3,7 +3,7 @@ import assert from 'assert';
 
 assert.strictEqual(Object.getPrototypeOf(import.meta), null);
 
-const keys = ['url'];
+const keys = ['resolve', 'url'];
 assert.deepStrictEqual(Reflect.ownKeys(import.meta), keys);
 
 const descriptors = Object.getOwnPropertyDescriptors(import.meta);

test/es-module/test-esm-loader-hooks.mjs

@@ -94,7 +94,6 @@ describe('Loader hooks', { concurrency: true }, () => {
  it('import.meta.resolve of a never-settling resolve', async () => {
  const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
  '--no-warnings',
- '--experimental-import-meta-resolve',
  '--experimental-loader',
  fixtures.fileURL('es-module-loaders/never-settling-resolve-step/loader.mjs'),
  fixtures.path('es-module-loaders/never-settling-resolve-step/import.meta.never-resolve.mjs'),
@@ -207,7 +206,6 @@ describe('Loader hooks', { concurrency: true }, () => {
  it('should not leak internals or expose import.meta.resolve', async () => {
  const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
  '--no-warnings',
- '--experimental-import-meta-resolve',
  '--experimental-loader',
  fixtures.fileURL('es-module-loaders/loader-edge-cases.mjs'),
  fixtures.path('empty.js'),
@@ -222,7 +220,6 @@ describe('Loader hooks', { concurrency: true }, () => {
  it('should be fine to call `process.exit` from a custom async hook', async () => {
  const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
  '--no-warnings',
- '--experimental-import-meta-resolve',
  '--experimental-loader',
  'data:text/javascript,export function load(a,b,next){if(a==="data:exit")process.exit(42);return next(a,b)}',
  '--input-type=module',