Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: validate writable defaultEncoding #46322

Merged
merged 4 commits into from
Jan 30, 2023
Merged

stream: validate writable defaultEncoding #46322

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68193ee
stream: validate writable defaultEncoding
marco-ippolito Jan 23, 2023
f9a2d21
stream: test falsy defaultEncoding
marco-ippolito Jan 24, 2023
1b96251
stream: test object mode
marco-ippolito Jan 24, 2023
958633d
stream: refactor code style
marco-ippolito Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stream: test falsy defaultEncoding
  • Loading branch information
@marco-ippolito
marco-ippolito committed Jan 24, 2023
commit f9a2d212e29ff4c94f6279a5f0ab5312bc3039f5
13 changes: 13 additions & 0 deletions test/parallel/test-stream-writable-decoded-encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,16 @@ class MyWritable extends stream.Writable {
w.write('asd');
w.end();
}

{
const w = new MyWritable(function(isBuffer, type, enc) {
assert(!isBuffer);
assert.strictEqual(type, 'string');
assert.strictEqual(enc, 'utf8');
}, {
defaultEncoding: null,
decodeStrings: false
});
w.write('asd');
w.end();
}