Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rename handlewrap.hasref tests #42754

Merged
merged 1 commit into from
May 5, 2022
Merged

test: rename handlewrap.hasref tests #42754

merged 1 commit into from
May 5, 2022

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Apr 16, 2022

HandleWrap.isRefed() was renamed to hasRef(). However, the filename
of related TCs has not been reflected.

Refs: f31a5ec34a

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Apr 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 17, 2022
Open
15 tasks
This was referenced Apr 18, 2022
Open
Open
@daeyeon
test: rename handlewrap.hasref tests
7a53e6b 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: nodejs@f31a5ec34a
@daeyeon daeyeon force-pushed the master.node-220416.Sat.dc24 branch from 1c799bc to 7a53e6b Compare April 19, 2022 17:44
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 20, 2022
Open
16 tasks
@daeyeon
Copy link
Member Author

daeyeon commented Apr 20, 2022

Can someone check if the Jenkins CI tests are flaky or timeout? Am I missing something? If not, please re-trigger them? Thanks in advance!

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Apr 21, 2022
Open
Open
Open
Open
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Apr 27, 2022
Open
Open
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced May 3, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43890/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit deb713e into nodejs:master May 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in deb713e

RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@daeyeon @RafaelGSS
test: rename handlewrap.hasref tests
41d2f6e 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: f31a5ec34a

PR-URL: #42754
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
@daeyeon daeyeon deleted the master.node-220416.Sat.dc24 branch May 25, 2022 03:01
juanarbol pushed a commit that referenced this pull request May 31, 2022
@daeyeon @juanarbol
test: rename handlewrap.hasref tests
aaa247c 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: f31a5ec34a

PR-URL: #42754
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@daeyeon @danielleadams
test: rename handlewrap.hasref tests
b6d7c85 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: f31a5ec34a

PR-URL: #42754
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@daeyeon @targos
test: rename handlewrap.hasref tests
955a7d6 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: f31a5ec34a

PR-URL: #42754
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@daeyeon @targos
test: rename handlewrap.hasref tests
c4d35b0 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: f31a5ec34a

PR-URL: #42754
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@daeyeon @guangwong
test: rename handlewrap.hasref tests
78b2814 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: nodejs/node@f31a5ec34a

PR-URL: nodejs/node#42754
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@daeyeon @nodejs-github-bot @jasnell @lpinca @tniessen @marsonya @RaisinTen @Mesteery @aduh95