debugger: Fix inconsistent inspector output of exec new Map()
#42423
+137
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
approved these changes
Mar 23, 2022
exec new Map()exec new Map()
|
The way these three commits are organized, the first commit adds a test that fails. This will break |
|
@Trott I squashed them into the one. |
Trott
approved these changes
Apr 17, 2022
14 tasks
jkrems
approved these changes
Apr 18, 2022
This was referenced Apr 19, 2022
jasnell
reviewed
Apr 20, 2022
| throw error; | ||
| } | ||
|
|
||
| cli.waitForInitialBreak() |
There was a problem hiding this comment.
oy... rather than a long chain of thens... can we convert this into an async function with awaits please?
This was referenced Apr 21, 2022
|
I think |
Most of them are. Maybe this one should be too. The ones in |
Trott
approved these changes
May 8, 2022
|
Landed in f890ef5 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
PR-URL: #42423 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
30 tasks
This was referenced May 12, 2022
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42423 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42423 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42423 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42423 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42423 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #42405
The output string of
execcommand is fromRemoteObject[customInspectSymbol], but currently it doesn't support some object types such asMapandSet, which leads to invalid string representations (#42405).This PR implemented string representations when
RemoteObject.subtypeissetandmap.RemoteObjecthas their abbreviation asObjectPreviewinRemoteObject.preview, which means we can construct their string representation fromObjectPreview.For example,
new Set([ {a: 1}, new Set([1]) ])is a RemoteObject that has two ObjectPreviews ({a: 1}andnew Set([1])).String representation of ObjectPreview
{a: 1}will be{a: 1}andnew Set([1])will beSet(1) { ... }. (Note that ObjectPreview treats an object nested in two or more layers as overflow, so overflowed object is converted to{ ... })1d0da48 added test cases for object type RemoteObject
7820dd4 added
ObjectPreviewandPropertyPreview. And current string representation logics are ported to them.5a4f767 fixed string representations of
MapandSet.