Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.14.2 proposal #24727

Merged
merged 376 commits into from
Dec 11, 2018
Merged

v10.14.2 proposal #24727

merged 376 commits into from
Dec 11, 2018

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 29, 2018 •
edited by MylesBorins

2018-12-11, Version 10.14.2 'Dubnium' (LTS), @MylesBorins prepared by @codebytere

This LTS release comes with 374 commits. This includes 165 which are test or benchmark related,
77 which are doc related, 29 which are build / tool related and 15 commits which update dependencies.

Notable Changes

nofwayy and others added 30 commits November 29, 2018 11:38
@nofwayy @MylesBorins
test: correct labelling of asserts errors
04ec990 
PR-URL: #23531
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@popopome @MylesBorins
test: fix strictEqual assertion argument in test-tls-ecdh-auto
e25f288 
PR-URL: #23530
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@ssamuels0916 @MylesBorins
test: fix assert.strictEqual() argument order
8a7fa5e 
PR-URL: #23529
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@parisandmilo @MylesBorins
test: corrected the order of arguments in assert.strictEqual()
c91497b 
PR-URL: #23528
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
test: use correct argument order for assert.strictEqual()
91816ad 
The previous code did not pass correct argument order to
assert.strictEqual().
Before:
First argument provided is expected value
Second argument provided is actual value

After:
First argument provided is actual value
Second argument provided is expected value

PR-URL: #23527
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
test: updating assertion and expect order in test-tls-client-verify.js
299285a 
PR-URL: #23547
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@seanhealy @MylesBorins
test: refactor callback functions to arrow functions
d54e15f 
Refactor callback functions to modern arrow functions.

Also, added `common.mustCall` to `online` callbacks.

PR-URL: #23546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@carlrc @MylesBorins
test: fix assertion argument order
643004f 
PR-URL: #23545
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@KelvinLawHF1 @MylesBorins
test: fix assertions argument order
a1ad454 
PR-URL: #23544
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codyhazelwood @MylesBorins
src: use MallocedBuffer abstraction for buffers
3d76ab9 
Drop `Free` and `std::unique_ptr` in favor of Node's `MallocedBuffer`
for `char[]` buffer memory mangement.

PR-URL: #23543
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@erin-bush @MylesBorins
test: swap expected and actual arguments in assert.strictEqual()
a8501e4 
PR-URL: #23542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@rxiayth @MylesBorins
test: added test for generateKeyPair
5292f54 
PR-URL: #23541
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@AllanZhengYP @MylesBorins
test: reverse the order of assertion statement arguments in pingpong …
f2d1045 
…test

PR-URL: #23540
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
test: fix assert.strictEqual() arguments order
f1c0538 
PR-URL: #23539
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jdenbroeder @MylesBorins
test: assert.strictEqual parameters ordered correctly
9bc7d83 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: #23538
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@chrisbautista @MylesBorins
test: switch strictEqual parameters - actual first before expected
29db84a 
PR-URL: #23537
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
test: fix strictEqual assertion order on readline tests
c641269 
PR-URL: #23561
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@naris93 @MylesBorins
test: modernize test-crypto-domain
699a1ac 
PR-URL: #23559
Reviewed-By: Sam Ruby <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins
test: fix order of assert arguments in vm-new-script-this-context
fcd273e 
Fixes the order of assert.strictEqual arguments.

PR-URL: #23558
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@peterjreynoldsii @MylesBorins
test: added async-hook benchmark
402cb65 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@jackelin-herrera @MylesBorins
test: reverse order of args in reconnect-error assert
f55a502 
PR-URL: #23555
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@frony @MylesBorins
build: add .DS_store to .gitgnore
d886095 
The following files were not being ignored:

deps/npm/node_modules/node-gyp/gyp/tools/.DS_Store
deps/npm/node_modules/node-gyp/gyp/tools/Xcode/.DS_Store

PR-URL: #23554
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@mhussa20 @MylesBorins
test: removed unused error variable in try catch
720262b 
In test/parallel/test-fs-access.js

PR-URL: #23553
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@crpahl @MylesBorins
test: update strictEqual arguments order
9a79824 
The argument order in the strictEqual check against stderr is in the
wrong order. The first argument is now the actual value and the second
argument is the expected value.

PR-URL: #23552
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@makitoda @MylesBorins
test: removed unused variable in fs-watch-file-slow
2498369 
PR-URL: #23548
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@jasonnutter @MylesBorins
test: fix order of parameters to assert.strictEqual
ff22625 
Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

PR-URL: #23590
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins
test: fix argument order in assertions
88cbb4a 
PR-URL: #23589
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorins
test: fix assert.strictEqual() parameter order in test-path-maklong.js
38b6fff 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: #23587
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@seantcoyote @MylesBorins
test: fix assertion arguments order
5604310 
There's no issue for this PR, it's a task at the Node+JS Code-n-Learn.

PR-URL: #23584
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@justin0022 @MylesBorins
test: increased code coverage for proxySessionHandler
3d1e51e 
PR-URL: #23583
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
cjihrig and others added 9 commits December 3, 2018 13:33
@cjihrig @MylesBorins
inspector: remove unused catch bindings
d79d978 
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig @MylesBorins
v8_prof_polyfill: remove unused catch bindings
80ab31e 
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig @MylesBorins
querystring: remove unused catch bindings
8001bee 
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig @MylesBorins
repl: remove unused catch bindings
4b456d5 
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig @MylesBorins
test: remove unused catch bindings
78be477 
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig @MylesBorins
benchmark: remove unused catch bindings
eed47b0 
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig @MylesBorins
tools: lint for unused catch bindings
a67e04e 
PR-URL: #24079
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@joyeecheung @MylesBorins
lib: move process prototype manipulation into setupProcessObject
a0b4f7a 
Since no operation is requiring process to be an EventEmitter before
setupProcessObject is called, it's safe to set up the prototype chain
in setupProcessObject and make the main code path more readable.

PR-URL: #24089
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danbev @MylesBorins
lib: add crypto dependant modules cannotUseCache
4035ca1 
This commit adds JavaScript modules that depend on crypto to
the cannotUseCache array. This is to avoid having them compiled when
node has been configured --without-ssl which currently fails.

PR-URL: #24100
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins force-pushed the v10.14.2-proposal branch 2 times, most recently from 3ea3714 to f875780 Compare December 3, 2018 18:43
@codebytere
Copy link
Member Author

codebytere commented Dec 3, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/19160/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1660/
rc.2: https://nodejs.org/download/rc/v10.14.2-rc.2/

@MylesBorins
Copy link
Contributor

MylesBorins commented Dec 3, 2018 •
edited

Lots of new failures compared to previous run

one more CI: https://ci.nodejs.org/job/node-test-pull-request/19165/

New CI was green... one more just to play it safe

https://ci.nodejs.org/job/node-test-pull-request/19182/

one more citgm for good measure too

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1661/

no build against 10.14.1 ~ https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/458

This was referenced Dec 5, 2018
Closed
Closed
@lpinca @MylesBorins
http: destroy the socket on parse error
fb99a4e 
Destroy the socket if the `'clientError'` event is emitted and there is
no listener for it.

Fixes: #24586

PR-URL: #24757
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
MylesBorins approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere
Copy link
Member Author

codebytere commented Dec 6, 2018 •
edited by MylesBorins

CI: https://ci.nodejs.org/job/node-test-pull-request/19275/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1671
rc.3: https://nodejs.org/download/rc/v10.14.2-rc.3/

edit (mylesborins): failure on arm due to infra

https://ci.nodejs.org/job/node-test-commit-arm-fanned/5038/

@codebytere @MylesBorins
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
4128793 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727
@DRoet
Copy link

DRoet commented Dec 11, 2018

Will #24757 still make it into this release?

@MylesBorins
Copy link
Contributor

@DRoet it is in fb99a4e

@MylesBorins MylesBorins merged commit 4128793 into v10.x Dec 11, 2018
MylesBorins added a commit that referenced this pull request Dec 11, 2018
@MylesBorins
Working on v10.14.3
4a858b2 
PR-URL: #24727
MylesBorins pushed a commit that referenced this pull request Dec 11, 2018
@codebytere @MylesBorins
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
6c6c563 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727
@MylesBorins MylesBorins mentioned this pull request Dec 11, 2018
Merged
@rvagg rvagg deleted the v10.14.2-proposal branch December 12, 2018 01:08
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@codebytere @refack
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
a2fa589 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    nodejs#23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    nodejs#23822
* Added new collaborators:
  * Peter Marshall. nodejs#24170
  * Masashi Hirano. nodejs#24136

PR-URL: nodejs#24727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet