deps: update V8 to 5.8 #12784

targos · 2017-05-02T09:11:05Z

This is the usual semver-major update for master. It should not land on v8.x (which will need the patch for V8 6.0 compatibility).

/cc @nodejs/v8

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/7792/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/676/

bnoordhuis

Rubberstamp LGTM. We can probably upstream some of the floating patches and request backports. I'll look into that this week, time permitting.

targos · 2017-05-02T12:13:54Z

Removed targos@3631085. It cherry-picked cleanly but the fix is already in 5.8 and the test addition got duplicated.

/cc @nodejs/platform-windows for the Windows error. Looks like it's related to #12184
/cc @nodejs/platform-freebsd for the FreeBSD error.

RReverser · 2017-05-02T12:27:54Z

@targos

It should not land on v8.x (which will need the patch for V8 6.0 compatibility).

In #12740 (comment) you said:

The plan is to update to 5.8 before we release 8.0.0

gibfahn · 2017-05-02T12:36:58Z

@RReverser so AIUI the vanilla 5.8 will directly land on master, then it'll be patched to make it ABI-compatible with V8 6.0 so we can then update to V8 6.0 for Node 8.0.0.

Having said that @targos is there any reason not to land this on Node 8 first and then land the ABI patch afterwards?

refack · 2017-05-02T12:47:15Z

/cc @nodejs/platform-windows for the Windows error. Looks like it's related to #12184

I'm building locally. #12184 is a good candidate, but I'm not sure...

targos · 2017-05-02T12:53:37Z

@gibfahn

Having said that @targos is there any reason not to land this on Node 8 first and then land the patch afterwards?

I'd be OK with that. I think @jasnell didn't want to break ABI compatibility between release candidates, but we have to wait for the patch anyway (otherwise the first RC would be with V8 5.7).

refack · 2017-05-02T18:22:21Z

@targos I've build this with and without #12184, and master with and without #12184
For master it fixes the issue.
For this PR it can only be built (on windows x86) without #12184, it seems the underlining issue (.lib file size) was resolved upstream.
@joaocgreis makes sense?

joaocgreis · 2017-05-02T19:37:20Z

@targos I might have found the root cause of this issue, but don't yet have a solution.

I believe this happens because the inspector sources are compiled together with the V8 sources in the v8_base libs. So, for each shard, a number of source files are compiled into obj files that are placed in the same folder. When runtime.cc is compiled together with Runtimce.cpp generated by inspector.gypi, the same runtime.obj file is generated twice, one being overwritten.

I don't know why we don't see a problem when it's the inspector file that is overwritten, nor why this is not a problem upstream. Is there a simple way to fix this from node?

refack · 2017-05-02T19:51:01Z

Is there a simple way to fix this from node?

@joaocgreis FWIW is work for me if I remove the #12184 fix.

jasnell · 2017-05-02T21:47:32Z

@targos ... I went ahead and put this on the 8.0.0 milestone so that I can track it. I'm going to need a PR for 8.x very soon if the intent is for 8.0.0 to go out the door with 5.8 /cc @MylesBorins

targos · 2017-05-03T09:06:07Z

A CI run with the canary branch shows that FreeBSD compilation is also broken on V8 master: https://ci.nodejs.org/job/node-test-commit-freebsd/8739/.

targos · 2017-05-04T09:37:43Z

@chvostek I saw you intervene in #3716. Would you maybe know people who can help us with the FreeBSD build issue?

joaocgreis · 2017-05-04T13:38:53Z

@targos I confirmed that this works for Windows if you leave 72326c57c3a588c343c2e03aadfe208230c3460a out. Changing the number of shards makes runtime.cc and Runtime.cpp end up in different shards. I'll try to find a more permanent solution.

targos · 2017-05-04T14:04:00Z

@refack, @joaocgreis OK, thanks. I removed that commit.

New CI: https://ci.nodejs.org/job/node-test-commit/9634/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/680/

targos · 2017-05-05T08:20:51Z

/cc @indutny

targos · 2017-05-05T13:47:50Z

CI with tentative fix: https://ci.nodejs.org/job/node-test-commit-freebsd/8819/

targos · 2017-05-05T14:06:57Z

freebsd-chromium has the same fix: https://github.com/gliaskos/freebsd-chromium/blob/master/www/chromium/Makefile#L202-L205

targos · 2017-05-05T19:43:07Z

This is ready to land. Can I have a review for the last commit? /cc @jasnell @fhinkel

This commit adds lldbinit files from upstream V8 and also adds these so that they get installed when `make install` is run. Original commit message: [tools] add lldbinit The goal of this commit is to add the equivalent to gdbinit but for lldb. I've tried to replicate the commands as close as possible but I'm unsure about the jss command and hoping to get some feedback on it in addition to the bta command which I'm not sure how/when this could be used. This is probably just inexperience on my part. The lldbinit file can be placed into a directory prefixed with dot (.lldbinit) and the python script is currently expected to be in the same directory. The path to the script can be changed manually if needed as well. NOTRY=true Review-Url: https://codereview.chromium.org/2758373002 Cr-Commit-Position: refs/heads/master@{nodejs#44136} PR-URL: nodejs#12061 Reviewed-By: Ben Noordhuis <[email protected]>

Original commit message: Update postmortem metadata generator. Add PropertyDetails::AttributesField + PropertyDetails::LocationField. Review-Url: https://codereview.chromium.org/2842843004 Cr-Commit-Position: refs/heads/master@{nodejs#44889} PR-URL: nodejs#12722 Refs: nodejs/llnode#81 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

targos · 2017-05-06T15:43:58Z

One last full CI run before landing: https://ci.nodejs.org/job/node-test-commit/9696/

PR-URL: #12784 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 5.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #12784 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

Use the -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 flag because on FreeBSD std::pairs copy constructor is non-trivial. Refs: https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html Refs: https://github.com/gliaskos/freebsd-chromium/blob/master/www/chromium/Makefile#L202-L205 PR-URL: #12784 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

targos · 2017-05-06T18:07:56Z

Landed in 73d9c0f...d74a545

fhinkel · 2017-05-07T04:48:22Z

LGTM 👍

jasnell · 2017-05-07T05:02:47Z

@targos ... I'm likely going to go ahead and pull this in to the 8.0.0 proposal with the expectation that the additional patch will be coming shortly. This will likely mean that RC.0 and RC.next will have a breaking ABI change, but it's important to get this into test builds as soon as possible.

Do you have an idea of when we can expect that additional patch?

targos · 2017-05-07T06:37:51Z

@jasnell

I'm likely going to go ahead and pull this in to the 8.0.0 proposal with the expectation that the additional patch will be coming shortly.

OK... The forward-compatibility patch for 5.8 -> 5.9 is already available. I'll open a PR as soon as 5.8 is in v8.x-staging.

Do you have an idea of when we can expect that additional patch?

I do not for 5.9 -> 6.0. @fhinkel might.

MylesBorins · 2017-05-07T07:54:47Z

The patch for 6.0 ABI compat is still going to be a little bit afaik. the original issue outlined that this ABI patch would need to land after the rc was cut.

I'll get a firmer date today

PR-URL: nodejs#12784 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 5.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: nodejs#12784 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

Use the -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 flag because on FreeBSD std::pairs copy constructor is non-trivial. Refs: https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html Refs: https://github.com/gliaskos/freebsd-chromium/blob/master/www/chromium/Makefile#L202-L205 PR-URL: nodejs#12784 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](nodejs@4a7233c178)] [nodejs#12892](nodejs#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](nodejs@d2d32ea5a2)] [nodejs#11968](nodejs#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](nodejs@7eb1b4658e)] [nodejs#12141](nodejs#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](nodejs@beca3244e2)] [nodejs#10236](nodejs#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](nodejs@97a77288ce)] [nodejs#12348](nodejs#12348), [[`d75fdd96aa`](nodejs@d75fdd96aa)] [nodejs#10423](nodejs#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](nodejs@627ecee9ed)] [nodejs#10653](nodejs#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](nodejs@f18e08d820)] [nodejs#9744](nodejs#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](nodejs@3c3b36af0f)] [nodejs#12936](nodejs#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](nodejs@60d1aac8d2)] [nodejs#12784](nodejs#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](nodejs@84dabe8373)] [nodejs#12489](nodejs#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](nodejs@7a55e34ef4)] [nodejs#10467](nodejs#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](nodejs@3c2a9361ff)] [nodejs#9683](nodejs#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](nodejs@90403dd1d0)] [nodejs#11567](nodejs#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](nodejs@d3480776c7)] [nodejs#11259](nodejs#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](nodejs@fb71ba4921)] [nodejs#11355](nodejs#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](nodejs@3e6f1032a4)] [nodejs#10805](nodejs#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](nodejs@5de3cf099c)] [nodejs#10116](nodejs#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](nodejs@84a23391f6)] [nodejs#12113](nodejs#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](nodejs@56e881d0b0)] [nodejs#11975](nodejs#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](nodejs@03e89b3ff2)] [nodejs#10116](nodejs#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](nodejs@dd20e68b0f)] [nodejs#12725](nodejs#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](nodejs@3f27f02da0)] [nodejs#11599](nodejs#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (nodejs@ec7cbaf266)] [nodejs#12995](nodejs#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](nodejs@a16b570f8c)] [nodejs#11968](nodejs#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](nodejs@010f864426)] [nodejs#12949](nodejs#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](nodejs@a5f91ab230)] [nodejs#11689](nodejs#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](nodejs@8a7db9d4b5)] [nodejs#12087](nodejs#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](nodejs@b6e1d22fa6)] [nodejs#12925](nodejs#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](nodejs@07c7f198db)] [nodejs#12828](nodejs#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](nodejs@348cc80a3c)] [nodejs#5923](nodejs#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](nodejs@a2ae08999b)] [nodejs#11349](nodejs#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](nodejs@d523eb9c40)] [nodejs#11447](nodejs#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](nodejs@d080ead0f9)] [nodejs#12710](nodejs#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](nodejs@5bfd13b81e)] [nodejs#9726](nodejs#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](nodejs@455e6f1dd8)] [nodejs#11708](nodejs#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](nodejs@aab0d202f8)] [nodejs#11624](nodejs#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](nodejs@99da8e8e02)] [nodejs#12442](nodejs#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](nodejs@91383e47fd)] [nodejs#12001](nodejs#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](nodejs@b514bd231e)] [nodejs#11391](nodejs#11391).

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](4a7233c178)] [#12892](#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](d2d32ea5a2)] [#11968](#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](7eb1b4658e)] [#12141](#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](beca3244e2)] [#10236](#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](97a77288ce)] [#12348](#12348), [[`d75fdd96aa`](d75fdd96aa)] [#10423](#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](627ecee9ed)] [#10653](#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](f18e08d820)] [#9744](#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](3c3b36af0f)] [#12936](#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](60d1aac8d2)] [#12784](#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](84dabe8373)] [#12489](#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](7a55e34ef4)] [#10467](#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](3c2a9361ff)] [#9683](#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](90403dd1d0)] [#11567](#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](d3480776c7)] [#11259](#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](fb71ba4921)] [#11355](#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](3e6f1032a4)] [#10805](#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](5de3cf099c)] [#10116](#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](84a23391f6)] [#12113](#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](56e881d0b0)] [#11975](#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](03e89b3ff2)] [#10116](#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](dd20e68b0f)] [#12725](#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](3f27f02da0)] [#11599](#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (ec7cbaf266)] [#12995](#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](a16b570f8c)] [#11968](#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](010f864426)] [#12949](#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](a5f91ab230)] [#11689](#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](8a7db9d4b5)] [#12087](#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](b6e1d22fa6)] [#12925](#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](07c7f198db)] [#12828](#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](348cc80a3c)] [#5923](#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](a2ae08999b)] [#11349](#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](d523eb9c40)] [#11447](#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](d080ead0f9)] [#12710](#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](5bfd13b81e)] [#9726](#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](455e6f1dd8)] [#11708](#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](aab0d202f8)] [#11624](#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](99da8e8e02)] [#12442](#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](91383e47fd)] [#12001](#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](b514bd231e)] [#11391](#11391).

targos added dont-land-on-v8.x semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels May 2, 2017

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 2, 2017

bnoordhuis approved these changes May 2, 2017

View reviewed changes

targos force-pushed the v8-5.8-master branch from d4a538f to e7804cb Compare May 2, 2017 12:13

gibfahn mentioned this pull request May 2, 2017

WebAssembly instantiation fails on latest nightly #12740

Closed

jasnell added this to the 8.0.0 milestone May 2, 2017

targos force-pushed the v8-5.8-master branch from e7804cb to f6b08e0 Compare May 4, 2017 14:01

targos force-pushed the v8-5.8-master branch 2 times, most recently from 487bc3f to 79dce0d Compare May 5, 2017 12:51

targos removed the dont-land-on-v8.x label May 5, 2017

targos force-pushed the v8-5.8-master branch from 79dce0d to 22162df Compare May 5, 2017 14:57

danbev and others added 2 commits May 6, 2017 17:37

targos force-pushed the v8-5.8-master branch from 22162df to 9ed7dcd Compare May 6, 2017 15:40

targos added a commit that referenced this pull request May 6, 2017

deps: update V8 to 5.8.283.38

60d1aac

PR-URL: #12784 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

targos closed this May 6, 2017

targos mentioned this pull request May 9, 2017

Build failure on Windows with V8 5.9 nodejs/v8#10

Closed

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017

deps: update V8 to 5.8.283.38

32a9e9b

PR-URL: nodejs#12784 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

jasnell mentioned this pull request May 11, 2017

8.0.0 Release Proposal #12220

Closed

targos deleted the v8-5.8-master branch June 1, 2017 07:38

jaimecbernardo mentioned this pull request Jun 28, 2017

deps,win: set MSVS .obj folders in gyp for V8 #13959

Closed

2 tasks

bnoordhuis mentioned this pull request Jul 4, 2017

Can't build stuff (using gyp) on FreeBSD 11.1 (or clang 4.0) #14076

Closed

nfalco79 mentioned this pull request Feb 14, 2018

Add support for BSD platforms (such as FreeBSD) jenkinsci/nodejs-plugin#20

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 5.8 #12784

deps: update V8 to 5.8 #12784

targos commented May 2, 2017 •

edited

Loading

bnoordhuis left a comment

targos commented May 2, 2017 •

edited

Loading

RReverser commented May 2, 2017

gibfahn commented May 2, 2017 •

edited

Loading

refack commented May 2, 2017

targos commented May 2, 2017

refack commented May 2, 2017

joaocgreis commented May 2, 2017

refack commented May 2, 2017

jasnell commented May 2, 2017

targos commented May 3, 2017

targos commented May 4, 2017

joaocgreis commented May 4, 2017

targos commented May 4, 2017

targos commented May 5, 2017

targos commented May 5, 2017

targos commented May 5, 2017

targos commented May 5, 2017

targos commented May 6, 2017

targos commented May 6, 2017

fhinkel commented May 7, 2017

jasnell commented May 7, 2017

targos commented May 7, 2017

MylesBorins commented May 7, 2017

deps: update V8 to 5.8 #12784

deps: update V8 to 5.8 #12784

Conversation

targos commented May 2, 2017 • edited Loading

Checklist

bnoordhuis left a comment

Choose a reason for hiding this comment

targos commented May 2, 2017 • edited Loading

RReverser commented May 2, 2017

gibfahn commented May 2, 2017 • edited Loading

refack commented May 2, 2017

targos commented May 2, 2017

refack commented May 2, 2017

joaocgreis commented May 2, 2017

refack commented May 2, 2017

jasnell commented May 2, 2017

targos commented May 3, 2017

targos commented May 4, 2017

joaocgreis commented May 4, 2017

targos commented May 4, 2017

targos commented May 5, 2017

targos commented May 5, 2017

targos commented May 5, 2017

targos commented May 5, 2017

targos commented May 6, 2017

targos commented May 6, 2017

fhinkel commented May 7, 2017

jasnell commented May 7, 2017

targos commented May 7, 2017

MylesBorins commented May 7, 2017

targos commented May 2, 2017 •

edited

Loading

targos commented May 2, 2017 •

edited

Loading

gibfahn commented May 2, 2017 •

edited

Loading