Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: should support userland Agent #11567

Closed
wants to merge 1 commit into from
Closed

http: should support userland Agent #11567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http: should support userland Agent
  • Loading branch information
@fengmk2
fengmk2 committed Feb 27, 2017
commit f17d533e4713d05b367ee21cec189e26fec2d67a
4 changes: 2 additions & 2 deletions lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ function ClientRequest(options, cb) {
}
// Explicitly pass through this statement as agent will not be used
// when createConnection is provided.
} else if (!(agent instanceof Agent.Agent)) {
} else if (typeof agent.addRequest !== 'function') {
throw new TypeError(
'Agent option must be an instance of http.Agent, undefined or false.'
'Agent option must be an Agent-like object, undefined, or false.'
);
}
self.agent = agent;
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http-client-reject-unexpected-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ server.listen(0, baseOptions.host, common.mustCall(function() {
failingAgentOptions.forEach((agent) => {
assert.throws(
() => createRequest(agent),
/^TypeError: Agent option must be an instance of http.Agent/,
/^TypeError: Agent option must be an Agent-like object/,
`Expected typeof agent: ${typeof agent} to be rejected`
);
});
Expand Down