-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TransformStream cleanup using "transformer.cancel" #49971
Labels
Comments
4 tasks
debadree25
added
feature request
Issues that request new features to be added to Node.js.
web streams
labels
Sep 30, 2023
lucacasonato
changed the title
Implement TransformStream cleanup using "transformer.cleanup"
Implement TransformStream cleanup using "transformer.cancel"
Sep 30, 2023
I am trying to implement this, i am coming across some weird behaviour for the test https://github.com/web-platform-tests/wpt/blob/1267d50de7f8adf06dbddaba00b4d9651ae146a4/streams/transform-streams/errors.any.js#L266 it seems after calling controller.error the writable stream should also error? if so cancelPromise should also throw because writable has entered errored state? or is node's behaviour wrong here? |
debadree25
added a commit
to debadree25/node
that referenced
this issue
Oct 1, 2023
debadree25
added a commit
to debadree25/node
that referenced
this issue
Oct 10, 2023
debadree25
added a commit
to debadree25/node
that referenced
this issue
Oct 10, 2023
debadree25
added a commit
to debadree25/node
that referenced
this issue
Oct 23, 2023
debadree25
added a commit
to debadree25/node
that referenced
this issue
Oct 23, 2023
debadree25
added a commit
to debadree25/node
that referenced
this issue
Nov 26, 2023
nodejs-github-bot
pushed a commit
that referenced
this issue
Dec 15, 2023
Fixes: #49971 PR-URL: #50126 Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
Dec 15, 2023
Fixes: #49971 PR-URL: #50126 Reviewed-By: Matteo Collina <[email protected]>
MattiasBuelens
pushed a commit
to MattiasBuelens/node
that referenced
this issue
May 1, 2024
Fixes: nodejs#49971 PR-URL: nodejs#50126 Reviewed-By: Matteo Collina <[email protected]>
MattiasBuelens
pushed a commit
to MattiasBuelens/node
that referenced
this issue
May 1, 2024
Fixes: nodejs#49971 PR-URL: nodejs#50126 Backport-PR-URL: nodejs#52772 Reviewed-By: Matteo Collina <[email protected]>
marco-ippolito
pushed a commit
that referenced
this issue
May 16, 2024
Fixes: #49971 PR-URL: #50126 Backport-PR-URL: #52772 Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The Streams specification has been updated with support for a hook to cleanup a TransformStream on error / abort. See whatwg/streams#1283. WPTs are available: web-platform-tests/wpt#40453
The text was updated successfully, but these errors were encountered: