-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal domain function can be used to cause segfaults #14519
Comments
4 tasks
tniessen
added a commit
to tniessen/node
that referenced
this issue
Jul 30, 2017
3 tasks
addaleax
pushed a commit
that referenced
this issue
Aug 2, 2017
PR-URL: #14548 Fixes: #14519 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following snippet will cause a segmentation fault on master:
This is caused by using
env->domain_array->Get(0)
instead of the safe variant of theGet
function. This is not limited torandomBytes
, there is a number of files with similar code.The priority of this issue is very low as it uses undocumented internal functions to intentionally cause a segmentation fault. I am documenting this for the sake of completeness.
The text was updated successfully, but these errors were encountered: