This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Fix off-by-one in handling upgrade bodies. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When handling upgraded bodies, http_parser_execute() used to return one fewer bytes parsed than expected. This caused the final LF to be interpreted by the caller as part of the body. - Add a bunch of upgrade body unit tests.
|
awesome +1 |
pgriess
added a commit
that referenced
this pull request
Jun 19, 2011
Fix off-by-one in handling upgrade bodies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one fewer bytes parsed than expected. This caused the final LF to be
interpreted by the caller as part of the body.