Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yarn to 1.0.2 for Node 8.5 #525

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Conversation

razor-x
Copy link
Contributor

@razor-x razor-x commented Sep 13, 2017

This includes a particularly critical bug fix for private packages: yarnpkg/yarn#4422

@razor-x
Copy link
Contributor Author

razor-x commented Sep 13, 2017

I can confirm that the update from yarn 0.27.5 (2924f14) broke our builds on node 8.5 but that yarn 1.0.2 does not have the corresponded bug.

Requesting this gets merged quickly 👍

@SimenB
Copy link
Member

SimenB commented Sep 14, 2017

@nodejs/docker What should be done here? Pretty bad bug

@pesho
Copy link
Contributor

pesho commented Sep 14, 2017

I'm torn. If this was the only change in Yarn 1.0.2 I'd say let's make a policy exception and upgrade it. But looking at the commit log there are 22 total commits between 1.0.1 and 1.0.2 so this is not a trivial/risk-free upgrade.

@SimenB
Copy link
Member

SimenB commented Sep 14, 2017

Full diff: yarnpkg/yarn@v1.0.1...v1.0.2

@SimenB
Copy link
Member

SimenB commented Sep 14, 2017

I think we should merge it, the other changes aren't too crazy IMO, and the bug is really bad.

@pesho
Copy link
Contributor

pesho commented Sep 14, 2017

Ok, in this case I agree. Does anyone else have objections?

@SimenB SimenB requested a review from a team September 14, 2017 11:40
SimenB

This comment was marked as off-topic.

@SimenB SimenB requested a review from a team September 14, 2017 11:40
@Starefossen
Copy link
Member

I'm looking through the commits for yarn 1.0.1 to 1.0.2 now

Starefossen

This comment was marked as off-topic.

@SimenB
Copy link
Member

SimenB commented Sep 14, 2017

@razor-x
Copy link
Contributor Author

razor-x commented Sep 14, 2017

Thanks all for pushing this exception though. Builds are humming along again 😀

@razor-x razor-x deleted the yarn-1.0.2 branch September 14, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants